[eas-cli] Add Appium simulator session support - #4190
Conversation
2ff5db9 to
0196214
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
==========================================
+ Coverage 63.54% 63.54% +0.01%
==========================================
Files 1030 1030
Lines 47262 47277 +15
Branches 9921 9926 +5
==========================================
+ Hits 30026 30039 +13
- Misses 17135 17137 +2
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0196214 to
96acf46
Compare
96acf46 to
566140e
Compare
566140e to
e8be5d1
Compare
99199e9 to
803e419
Compare
803e419 to
af1c77c
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
| SIMULATOR_DOTENV_FILE_HEADER + | ||
| Object.entries(environmentVariables) | ||
| .map(([key, value]) => `${key}=${JSON.stringify(value)}`) | ||
| .map(([key, value]) => `${key}='${value}'`) |
There was a problem hiding this comment.
not sure if we should be concerned but:
Raw single-quote wrapping does not round-trip every valid capability value. For example, capabilities containing
It's #1are truncated at#by dotenv 16.3.1 because the inner apostrophe defeats quoted parsing. The new shell-export instructions similarly fail on apostrophes. Could we use format-specific escaping and add an apostrophe-plus-hash regression test?
| APPIUM_URL: remoteConfig.appiumUrl, | ||
| APPIUM_CAPS: JSON.stringify(remoteConfig.capabilities), |
There was a problem hiding this comment.
follow-up request: can we protect it via token as well?
2 participants
Why
Now that we support Appium sessions, eas-cli needs to support it too.
How
Added spread on GraphQL fetch, special instructions for printing and env file.
Test Plan
CI should pass. Also ran a local e2e test.