Fix broken GitHub link in website navbar - #14031
Open
Obila34 wants to merge 1 commit into
Open
Conversation
The GitHub button in the top right of the website navbar is rendered by react-github-btn with data-show-count enabled. The github-buttons widget builds the star count link by appending /stargazers to the repo URL, and GitHub no longer serves that page (it now returns a 404), so the count link in the navbar was broken. Remove data-show-count so the navbar renders a plain GitHub button that links directly to https://github.com/explosion/spaCy. Also add the signed contributor agreement for Obila34.
There was a problem hiding this comment.
馃煝 Approval recommended
The change is minimal, matches the stated root cause, and resolves the broken-link behavior without introducing additional risk.
Pull request overview
This PR fixes a broken GitHub link in the spacy.io website navbar by adjusting the react-github-btn configuration so it no longer generates a star-count link to the deprecated /stargazers URL. It also adds the author鈥檚 signed contributor agreement file as required for first-time contributions.
Changes:
- Remove
data-show-count="true"from the navbar GitHub button to prevent generation of the/stargazerslink. - Add a signed spaCy contributor agreement under
.github/contributors/.
File summaries
| File | Description |
|---|---|
website/src/components/navigation.js |
Disables the GitHub star-count link that was pointing to a 404 by removing data-show-count. |
.github/contributors/Obila34.md |
Adds the contributor agreement document for the new contributor. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14030.
The GitHub button in the top right of the spacy.io navbar linked to https://github.com/explosion/spaCy/stargazers, which returns a 404 (GitHub no longer serves the public stargazers page).
Root cause: the navbar button in
website/src/components/navigation.jsis rendered withreact-github-btnanddata-show-count="true". The underlying github-buttons widget builds the star-count link by appending/stargazersto the repo URL (see thestargazers_countbranch in github-buttons' href logic), so the count portion of the widget pointed at the now-removed page.Change: remove
data-show-count="true"so the widget renders a plain GitHub button that links directly to https://github.com/explosion/spaCy.Verification: confirmed via curl that
https://github.com/explosion/spaCy/stargazersreturns 404 whilehttps://github.com/explosion/spaCyreturns 200; confirmed in github-buttons 2.22.1 (the version pinned inwebsite/package-lock.json) that the/stargazerssuffix is only added for the count link whendata-show-countis enabled, so removing the attribute leaves a single link to the repository. The server-rendered fallback anchor (href={github()}) already points to the repo and is unchanged.This is my first contribution, so the PR also adds my signed contributor agreement (
.github/contributors/Obila34.md).Types of change
Bug fix (website).
Checklist