Skip to content

ci(cla): never lock a pull request when it closes - #434

Merged
itsskofficial merged 1 commit into
mainfrom
ci/cla-no-lock
Oct 17, 2026
Merged

itsskofficial merged 1 commit into
mainfrom
ci/cla-no-lock

Conversation

@itsskofficial

@itsskofficial itsskofficial commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

The CLA action's lock-pullrequest-aftermerge defaults to true, and it locks a PR's conversation whenever the PR closes, merged or not.

Today a maintainer closed and reopened #412 to start its CI. The bot locked it within 8 seconds, after which:

  • the CLA check failed with "Unable to create comment because issue is locked";
  • CodeRabbit skipped the PR;
  • the contributor couldn't comment.

It would also break the stale-PR policy from #416, which closes PRs with a note saying the contributor can reopen them any time.

This sets lock-pullrequest-aftermerge: false. Nothing else changes.

Real test

Summary by CodeRabbit

  • Changes
    • Pull requests are no longer automatically locked after merging, so they remain available for continued interaction. Existing access rules are unchanged.

@itsskofficial itsskofficial added the no changelog No changes/ entry needed: users won't notice this change label Oct 17, 2026
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 96ffd544-20ae-4491-8b49-fa69c9af4a81
📥 Commits

Reviewing files that changed from the base of the PR and between ebf9a10 and 20ba18d.

📒 Files selected for processing: 1
  • .github/workflows/cla.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

The CLA Assistant configuration now disables pull-request locking after merge. The allowlist remains unchanged.

Changes: CLA pull request locking

Layer / File(s) Summary
Post-merge locking setting
.github/workflows/cla.yaml
The configuration sets lock-pullrequest-aftermerge to false. The allowlist remains unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 20ba1

Closed pull requests can remain commentable instead of being locked by the CLA action. No actionable merge risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 20ba1

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/cla.yaml: The allowlist remains unchanged. Comments describe the action’s closure-locking behavior and the consequences for stale or maintainer-closed pull requests and reopened pull requests; the configuration now disables locking after merge.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: disabling pull-request locking when the CLA action closes a pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the CLA flow,
And sees the lock set down to go.
The allowlist stays as it was,
While merged pull requests rest because.
Soft paws hop on, the work is done.

Comment @coderabbitai help to get the list of available commands.

@itsskofficial
itsskofficial added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit 5120c3c Oct 17, 2026
9 of 10 checks passed
@itsskofficial
itsskofficial deleted the ci/cla-no-lock branch October 17, 2026 16:00
@itsskofficial

Copy link
Copy Markdown
Contributor Author

Verified after merge: I opened a throwaway draft PR (#437) and closed it. The CLA workflow ran on the close, and #437 stayed unlocked (locked=false, no locked event). Before this change, #412 was locked 8 s after closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog No changes/ entry needed: users won't notice this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant