Repository navigation
ci(cla): never lock a pull request when it closes - #434
Merged
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLA action's
lock-pullrequest-aftermergedefaults to true, and it locks a PR's conversation whenever the PR closes, merged or not.Today a maintainer closed and reopened #412 to start its CI. The bot locked it within 8 seconds, after which:
It would also break the stale-PR policy from #416, which closes PRs with a note saying the contributor can reopen them any time.
This sets
lock-pullrequest-aftermerge: false. Nothing else changes.Real test
github-actions[bot]8 s after the reopen; the issue events showclosed14:41:50,reopened14:41:52,locked14:42:00. I unlocked it by hand.Summary by CodeRabbit