Skip to content

Refactor Analyzer Tests to Use Sample Solution Files Instead of Multi-Line Strings #24

Description

@BethanyG

Per the conversation in PR#22, the test cases as written in test/two-fer/two_fer_test.py are not syntax highlighted and are difficult to scan. In their current multi-line string form, they are also brittle (an extra space or other error will cause failure) and hard to maintain.

Ideally, we'd refactor the tests and testing code to read sample files from a test/samples/ directory, or the test/ directory itself, and compare results with "known good" or "known output" -- similar to this approach in the Python test runner, and this approach in the Ruby Analyzer.

We could also model the test input as Pytest Fixtures, similar to the approach used in the C# Analyzer.

Because the current model is to have a test directory for every analyzer and an analyzer directory for every exercise, it's important we move to a clearer and more modular solution for test files.

Activity

  1. BethanyG commented on Apr 16, 2021

    @BethanyG
    MemberAuthor

    Tagging this as part of issue #11 .

  2. self-assigned this
    on May 9, 2021
  3. BethanyG commented on Feb 21, 2026

    @BethanyG
    MemberAuthor

    Partially fixed in #74. But the two-fer tests still need changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

x:status/claimedSomeone is working on this issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions