Fix CI: expect v3 results.json and run on amd64#190
Merged
Conversation
The factor-test-runner image was rewritten in May to emit
{"version":3, ...}, but bin/.test-in-docker still grepped for
{"version":1,"status":"pass"} — so every example solution was
reported "Solution is incorrect: null" (the v3 pass payload has no
top-level .message). Switch the check to read top-level .status and
build the failure message from .message (error case) or per-test
.message values (fail case).
The image is now amd64-only on Docker Hub. Run the workflow on
ubuntu-24.04 instead of ubuntu-24.04-arm so the Factor VM runs
natively rather than under QEMU emulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/.test-in-dockernow reads top-level.statusfrom the v3results.jsoninstead of grepping for the old v1 shape, so passing example solutions are recognised again. On failure it surfaces either the top-level.message(error case) or the per-test.messagevalues (fail case)..github/workflows/test.ymlruns onubuntu-24.04rather thanubuntu-24.04-arm, matching the amd64-only image currently published on Docker Hub. This avoids running the Factor VM under QEMU emulation.The May rewrite of
factor-test-runnerswitched the runner's output to{"version":3, ...}. The integration check in this repo still grepped for{"version":1,"status":"pass"}, which never matched — so every exercise printedSolution is incorrect: null(a passing v3 result has no top-level.message, sojq -r '.message'yieldsnull). Last green CI run was 2026-05-02 (#188), immediately before those runner changes landed.Test plan
Track Exercises on Runnerto green