Skip to content

Conversation

@angelikatyborska
Copy link
Member

No description provided.

@angelikatyborska
Copy link
Member Author

I believe the dialyzer errors are caused by elixir-lang/elixir#14837

@angelikatyborska
Copy link
Member Author

This one as well: jeremyjh/dialyxir#563 but it was created before Elixir 1.19.0 was released 🤔 unless somebody tested on a rc version.

@angelikatyborska
Copy link
Member Author

@jiegillet Did you encounter this error at work maybe? I have no idea what to do.

@neenjaw
Copy link
Contributor

neenjaw commented Nov 5, 2025

is it possible it is using an old plt that is incompatible with the new version?

@angelikatyborska
Copy link
Member Author

The cache key on Github CI includes the exact Elixir version and file has of mix.lock, so unlikely. I also tested locally by deleting plts first, same results 😞

@dabaer
Copy link
Contributor

dabaer commented Nov 6, 2025

I've also encountered the dialyxer issue at work, unfortunately no amount of build and plt cleaning or config tweaking resolves the errors.

Hopefully it's fixed soon upstream

@angelikatyborska angelikatyborska marked this pull request as ready for review November 7, 2025 08:38
@angelikatyborska
Copy link
Member Author

angelikatyborska commented Nov 7, 2025

It worked! 🎉 It required upgrading dialyxir to 1.4.7 and Elixir to 1.19.2, as well as adding a flags: [:no_opaque] flag to the dialyzer config (as suggested in elixir-lang/elixir#14837 (comment))

This PR could be approved and merged right now, but I'm still waiting on an official 1.19.2 Docker image for the tooling repos.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you for doing it and figuring out the dialyzer errors.

There is one more thing we should change, the mapset concept and gotta-snatch-em-all have specific references to Elixir 1.15 because it introduced MapSet.split_with. Now we can actually use that function and pretend it's been there forever. If you grep for Elixir 1.15 you should find all the mentions.

@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?
  • Concept changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <concept>/.meta/config.json (see docs)?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@angelikatyborska angelikatyborska merged commit 8d533bd into main Nov 16, 2025
8 checks passed
@angelikatyborska angelikatyborska deleted the elixir-1-19 branch November 16, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants