-
-
Notifications
You must be signed in to change notification settings - Fork 406
Update to Elixir 1.19 #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Elixir 1.19 #1603
Conversation
|
I believe the dialyzer errors are caused by elixir-lang/elixir#14837 |
|
This one as well: jeremyjh/dialyxir#563 but it was created before Elixir 1.19.0 was released 🤔 unless somebody tested on a rc version. |
|
@jiegillet Did you encounter this error at work maybe? I have no idea what to do. |
|
is it possible it is using an old plt that is incompatible with the new version? |
|
The cache key on Github CI includes the exact Elixir version and file has of mix.lock, so unlikely. I also tested locally by deleting plts first, same results 😞 |
|
I've also encountered the dialyxer issue at work, unfortunately no amount of build and plt cleaning or config tweaking resolves the errors. Hopefully it's fixed soon upstream |
|
It worked! 🎉 It required upgrading dialyxir to 1.4.7 and Elixir to 1.19.2, as well as adding a This PR could be approved and merged right now, but I'm still waiting on an official 1.19.2 Docker image for the tooling repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thank you for doing it and figuring out the dialyzer errors.
There is one more thing we should change, the mapset concept and gotta-snatch-em-all have specific references to Elixir 1.15 because it introduced MapSet.split_with. Now we can actually use that function and pretend it's been there forever. If you grep for Elixir 1.15 you should find all the mentions.
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
jiegillet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
No description provided.