Repository navigation
Fix list_projects date-time schema failures and wildcard filter crash - #2730
Merged
Merged
Conversation
Older projects and stacks were stored without a time zone, so their dates serialized without a Z and failed the output schema's date-time format, breaking list_projects for MCP clients that validate structured output. A type-info modifier on the MCP serializer (and Exie's) now writes every DateTime as UTC without changing the generated output schema. list_projects with a leading wildcard such as name:*web* threw an unhandled Elasticsearch error; it now returns invalid_filter like search_stacks and search_events.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d03b87bc26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two
list_projectsfailures seen from Claude Code againstbe.exceptionless.io/mcp.What broke
list_projects(org with old projects)createdUtc must match format "date-time"list_projectswithfilter: "name:*web*"An error occurred invoking 'list_projects'(unhandled ES 400)Causes and fixes
Z: older documents were stored without a time zone, read back asDateTimeKind.Unspecified, and serialized as2016-01-11T20:05:59.7185672. RFC 3339date-timeneeds a zone.McpJsonSerializerOptions.Defaultadds a type-info modifier that writes everyDateTime/DateTime?property as UTC (Unspecified→ UTC,Local→ converted).WithTools<ExceptionlessMcpTools>(...), the unknown-argument error result, and Exie's tool-result serializer, so it covers projects, stacks, events, counts, context, anddetails.projectsin errors.format: date-timein the generated output schema.invalid_filter.ProjectFilterDescriptiondocumentsname:web/name:web*.Tests
ListProjectsAsync_DatesStoredWithoutTimeZone_SerializeAsUtc(stores anUnspecifiedproject, checks every date has a zone)Serialize_DatesWithoutTimeZone_WritesUtc,Serialize_LocalAndUtcDates_WritesSameInstantInUtc,ListProjects_OutputSchemaAdvertisesDateTimeFormatListProjectsAsync_LeadingWildcardFilter_ReturnsInvalidFilter,ListProjectsAsync_TrailingWildcardNameFilter_ReturnsMatchingProjectsExceptionless.Tests.Mcp+Exceptionless.Tests.Assistant: 507 passed, 26 skipped (evals), 0 failedNot in scope
The REST API still returns old dates without
Z(the browser parses those as local time). Same modifier could go onConfigureExceptionlessApiDefaultsin a follow-up.