Replace Windows Live authentication with Microsoft - #2403
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68278822f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 716f6d7911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # src/Exceptionless.Web/ClientApp/src/lib/features/auth/index.svelte.ts
d3d23d0 to
ec96f56
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
MicrosoftClientWindowsLiveidentity only after a successful Microsoft response for the authenticated user, an existing modern identity, or an exact-email matchMicrosoftIdconfiguration slots, and expose the renamed public client-ID constant without logging OAuth secret valuesThis intentionally does not change self-hosting documentation, Kubernetes values, Docker Compose samples, the vendored Satellizer library, or unrelated HTTP samples.
Migration behavior
Microsoft setup
window.location.origin, so it must match the deployed origin exactly.User.Readand create a client secret.MicrosoftId=<client-id>;MicrosoftSecret=<secret>;inEX_ConnectionStrings__OAuth.The server uses the OAuth2 library's Microsoft client: https://github.com/titarenko/OAuth2
Breaking changes
POST /api/v2/auth/liveand replaces it withPOST /api/v2/auth/microsoftVerification
dotnet build --no-restore: 0 warnings, 0 errorsmain: 56 passedLive Microsoft consent and callback verification remains pending a real client ID and secret.