Skip to content

Refresh event grids after deletion#2398

Open
niemyjski wants to merge 1 commit into
mainfrom
issue/event-delete-grid-refresh
Open

Refresh event grids after deletion#2398
niemyjski wants to merge 1 commit into
mainfrom
issue/event-delete-grid-refresh

Conversation

@niemyjski

@niemyjski niemyjski commented Jul 24, 2026

Copy link
Copy Markdown
Member

What changed

  • Reconcile organization Events, Sessions, Stream, Stack, and project Stack grids after deletions without requiring a page refresh.
  • Add immediate and bounded post-delete fallbacks for silently lost or delayed push notifications, including direct Stack-query invalidation when its route is not mounted.
  • Refresh manual grids after WebSocket reconnect in both the Svelte and legacy Angular UIs.
  • Make browser code 1006 reconnectable while the API reports rejected push authentication explicitly as terminal close code 4401.
  • Keep reconnects safe across token rotation, canceled backoff timers, route teardown, navigation, and slow out-of-order search responses.
  • Correct empty cursor/page boundaries after deletion and preserve accurate bulk-delete success counts.

Why

Event deletion returns 202 before Elasticsearch-backed list and aggregate views are necessarily consistent. The Svelte Events grid removed a visible row when a push notification arrived but normally skipped an authoritative reload unless the page became empty. Replacement rows, cursor metadata, off-page removals, and related Stack summaries could therefore remain stale until F5.

Push timing was a contributor but could not be the sole correctness mechanism: notifications may be delayed or silently lost, and browser close code 1006 is ambiguous. The fix combines immediate UI feedback, bounded authoritative reconciliation, direct query invalidation, and reconnect-wide refresh.

Verification

  • Svelte npm run validate
  • Svelte npm run test:unit — 24 files / 305 tests passed
  • Svelte production build
  • Legacy Angular targeted Prettier and ESLint checks
  • Legacy Angular production build
  • Focused backend WebSocket tests — 3 passed
  • Svelte dogfood:
    • single and bulk deletes, filtered Errors, page 2, and emptied final-page recovery
    • navigation with pending reconciliation
    • Sessions, Stack, project Stack, and Stream refresh behavior
  • Legacy Angular dogfood:
    • delete automatically refreshed list/count data
    • API interruption/reconnect automatically refreshed the active grid
  • Browser protocol dogfood against rebuilt API:
    • invalid token closed cleanly with code 4401 and reason Unauthorized
  • Two independent fixed-point code-review passes completed with no remaining findings.

Breaking changes

None.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 160340cb85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/event/+page.svelte Outdated
Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte
@niemyjski
niemyjski force-pushed the issue/event-delete-grid-refresh branch from 160340c to 88f0a71 Compare July 24, 2026 14:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88f0a71fc5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@niemyjski
niemyjski force-pushed the issue/event-delete-grid-refresh branch from 88f0a71 to 1c564b2 Compare July 24, 2026 15:16
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Core 73% 65% 9497
Exceptionless.AppHost 38% 40% 139
Exceptionless.Insulation 23% 23% 205
Exceptionless.Web 84% 67% 6900
Summary 77% (22527 / 29444) 65% (10343 / 15824) 16741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant