Include `ref.parent` matches in events by-reference navigation by Copilot · Pull Request #2280 · exceptionless/Exceptionless

Copilot · 2026-05-31T23:58:55Z

/events/by-ref/{referenceId} only matched reference:{id}, so child events that stored their relationship in ref.parent could not be reached through Parent navigation.

Root cause

The by-reference handlers queried only the top-level reference field.
Adding ref.parent to the query initially made the route premium-only because dynamic reference fields were classified as premium.
Free-plan ingestion also skipped dynamic indexing, so real posted events did not persist idx.parent-r even though test fixtures did.
The Svelte event-list link still emitted a direct-reference-only filter, dropping parent matches after navigation.
Reference IDs were constrained, but programmatic reference names were not validated at the write boundary even though indexing only accepts field names with 1–25 letters, digits, or hyphens.

Changes

Match either reference:{id} or ref.parent:{id} in organization- and project-scoped handlers and frontend navigation.
Classify the built-in parent reference as free so existing by-reference behavior remains available to free organizations.
Index only @ref:parent for free-plan events; arbitrary custom data remains unindexed.
Run versioned migration 3 to backfill missing idx.parent-r values for retained events without overwriting existing indexes.
Validate programmatic reference names against the existing index field-name contract, and reject invalid ref.<name> query fields.
Render arbitrary valid reference filters as ref.<name> and suppress unsafe/invalid filter controls.
Centralize built-in parent and session reference names.
Add endpoint, query-validator, production-pipeline, reference-filter, and identifier coverage.
Merge the latest origin/main into the PR branch.

Verification

dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore --disable-build-servers -m:1 — 0 warnings, 0 errors.
StringExtensionsTests — 43 passed.
PersistentEventQueryValidatorTests — 70 passed.
EventPipelineTests — 60 passed, 1 intentional skip.
EventEndpointTests — 104 passed.
BackfillParentReferencesMigrationTests — passed against Elasticsearch.
Frontend reference-filter unit tests — 77 passed.
npm run validate — passed (Prettier, ESLint, and Svelte check with 0 errors/warnings).
Scoped dotnet format --verify-no-changes — passed.
Previous full backend suite — 2,424 passed, 2 intentional skips, 0 failed.
Thermo-nuclear maintainability review — passed with no unresolved PR-scope findings.

Compatibility and scope

No route, response-contract, or authorization changes.
Existing direct-reference matches remain supported.
Reference IDs remain constrained by the identifier route constraint and event validation to 8–100 letters, digits, or hyphens.
Raw legacy events containing invalid reference names are preserved but those invalid names are not indexed; new programmatic writes reject them.
Newly ingested free-plan events persist only the built-in idx.parent-r search field; arbitrary dynamic reference fields remain premium-only.
Arbitrary valid premium reference names still consume dynamic Elasticsearch mappings. The index total-field limit is a failure ceiling, not cardinality governance; managed organization-scoped custom-field slots remain a separate follow-up.

CLAassistant · 2026-05-31T23:59:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ niemyjski
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>

# Conflicts: # src/Exceptionless.Web/Controllers/EventController.cs

…ref-navigation

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae3cc52eb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f152edde5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 775c14f17c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f0dd46364

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-21T03:28:12Z


-        return `reference:${quoteIfSpecialCharacters(this.value)}`;
+        const reference = quoteIfSpecialCharacters(this.value);
+        return `(reference:${reference} OR ref.parent:${reference})`;


Keep parent reference filters free in the Svelte guard

When this filter is used on the events route, (app)/+layout.svelte calls filterUsesPremiumFeatures() on the filter query string, and premium-filter.ts still treats any ref.parent field as premium because its free-field list only contains reference/reference_id. For free-plan organizations, clicking a Reference filter or the by-ref page's “View In Events” link now shows the premium-upgrade notification even though the backend validator intentionally made parent-reference lookup free; the client free-field list needs the same ref.parent allowance.

Useful? React with 👍 / 👎.

…ref-navigation-4d0e

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a507d669da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-26T01:58:48Z

+        if (!name.IsValidFieldName())
+            throw new ArgumentException("Name must contain between 1 and 25 alphanumeric or '-' characters.", nameof(name));


Keep SetEventReference backward compatible

When an existing caller uses a custom reference name that was previously accepted, such as order_id or a name longer than 25 characters, this new guard now throws instead of storing @ref:<name>. SetEventReference is public, and the indexing/query paths already skip names they cannot safely index, so rejecting those names at the write boundary introduces an unapproved behavioral break; preserve storage compatibility or explicitly version the API change. This is a review BLOCKER under the repository guidance.

AGENTS.md reference: AGENTS.md:L67-L67

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-26T01:58:48Z

+    {
+        string referenceKey = $"@ref:{Event.KnownReferenceNames.Parent}";
+        string indexKey = $"{Event.KnownReferenceNames.Parent}-r";
+        string script = $"if (ctx._source.data != null && ctx._source.data.containsKey('{referenceKey}') && ctx._source.data['{referenceKey}'] != null) {{ if (ctx._source.idx == null) ctx._source.idx = [:]; ctx._source.idx['{indexKey}'] = ctx._source.data['{referenceKey}']; }} else {{ ctx.op = 'noop'; }}";


Normalize legacy parent values before backfilling

When a retained event contains a non-string data["@ref:parent"] value—which raw legacy DataDictionary records permit—this script assigns the map, list, or other value directly to the idx.parent-r keyword field rather than applying the string normalization used by CopyDataToIndex. Elasticsearch can reject that update with a mapping failure, and the later completion branch does not inspect the task's embedded failures, allowing migration version 3 to be recorded as complete while some valid records remain unbackfilled; filter or normalize legacy values and fail/retry when the task reports failures.

AGENTS.md reference: AGENTS.md:L72-L75

Useful? React with 👍 / 👎.

github-actions · 2026-07-26T02:05:10Z

Package	Line Rate	Branch Rate	Complexity	Health
Exceptionless.Core	73%	65%	9532	➖
Exceptionless.AppHost	38%	40%	139	❌
Exceptionless.Insulation	23%	23%	205	❌
Exceptionless.Web	84%	67%	6935	✔
Summary	77% (22581 / 29513)	65% (10374 / 15892)	16811	✔

Copilot AI assigned Copilot and niemyjski May 31, 2026

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request

Exceptionless 4.1.0 cannot navigate from the 'Parent' url #1287

Closed

Copilot AI changed the title ~~[WIP] Fix navigation issue from 'Parent' URL in Exceptionless 4.1.0~~ Include ref.parent matches in events by-reference navigation Jun 1, 2026

Copilot AI requested a review from niemyjski June 1, 2026 00:11

Copilot AI and others added 2 commits July 10, 2026 13:32

fix(events): include parent references in by-ref navigation

f09562e

Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>

test(http): cover event by-reference routes

8f5e641

niemyjski force-pushed the copilot/fix-parent-url-navigation branch from e666187 to 8f5e641 Compare July 10, 2026 18:47

niemyjski changed the base branch from bugfix/1287-investigate-references to main July 10, 2026 18:47

niemyjski added 2 commits July 15, 2026 21:22

Merge origin/main into copilot/fix-parent-url-navigation

ae3cc52

# Conflicts: # src/Exceptionless.Web/Controllers/EventController.cs

Merge remote-tracking branch 'origin/main' into issue/pr-2280-parent-…

311c5d5

…ref-navigation

niemyjski marked this pull request as ready for review July 21, 2026 02:08

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/Api/Handlers/EventHandler.cs Outdated

fix(events): keep parent navigation available on free plans

6f152ed

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Repositories/Queries/Validation/PersistentEventQueryValidator.cs Outdated

fix(events): index parent references for free plans

775c14f

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Pipeline/035_CopySimpleDataToIdxAction.cs Outdated

Comment thread src/Exceptionless.Web/Api/Handlers/EventHandler.cs Outdated

niemyjski added 2 commits July 20, 2026 22:16

fix(events): validate and align reference filters

0e94773

fix(events): backfill retained parent references

5f0dd46

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

niemyjski added 2 commits July 25, 2026 20:26

Merge remote-tracking branch 'origin/main' into issue/pr-2280-parent-…

6942014

…ref-navigation-4d0e

fix(events): align free parent reference navigation

a507d66

chatgpt-codex-connector Bot reviewed Jul 26, 2026

View reviewed changes

		if (!name.IsValidFieldName())
		throw new ArgumentException("Name must contain between 1 and 25 alphanumeric or '-' characters.", nameof(name));

Uh oh!

Uh oh!

Conversation

Copilot AI commented May 31, 2026 • edited by niemyjski Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause

Changes

Verification

Compatibility and scope

Uh oh!

CLAassistant commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 31, 2026 •

edited by niemyjski

Loading

CLAassistant commented May 31, 2026 •

edited

Loading