build: add isolated v2 FlatBuffers protocol library - #22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e02f8551e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5c750f0 to
dc4f843
Compare
fb798ee to
b70e698
Compare
| } | ||
|
|
||
| void verify_symbols(const std::string& archive_path) { | ||
| const std::string command = "nm -g --defined-only -- '" + archive_path + "'"; |
There was a problem hiding this comment.
this we need to fix later, the AI tried to cheat
There was a problem hiding this comment.
i do agree; tried implementing some code that really use the flatbuffer symbols, but it seems a lot of changes; therefore, i leave it as it is for this PR and create an issue for this
| } | ||
|
|
||
| void verify_symbols(const std::string& library_path) { | ||
| const std::string command = "nm -D --defined-only -- '" + library_path + "'"; |
There was a problem hiding this comment.
this we need to fix later, the AI tried to cheat
2 participants
Summary
udf_protocol.fbswith BazelValidation
bazel test --lockfile_mode=off //:udf_protocol_test //:udf_protocol_symbol_leak_testbazel build --lockfile_mode=off //:udf_protocol //:udf_protocol_sharedBoth were run with Bazel 8.3.1.