The existing tests under udf_protocol_symbol_leak_test.cc and udf_protocol_static_symbol_leak_test.cc are not sufficient. As of now it simply tests if the mangled-flatbuffer symbols are available in the exported protocol-shared-library. This is required but not enough.
The correct way is to implement some tests that
- really uses the flatbuffer symbols exported by the protocol-shared-library to create a Frame
- use the VerifyFrameBuffer to verify the Frame
- the tests shall fail if there are symbols that belongs to
flatbuffers:: instead of exasol::udf::v2::third_party::flatbuffers::
The existing tests under
udf_protocol_symbol_leak_test.ccandudf_protocol_static_symbol_leak_test.ccare not sufficient. As of now it simply tests if the mangled-flatbuffer symbols are available in the exported protocol-shared-library. This is required but not enough.The correct way is to implement some tests that
flatbuffers::instead ofexasol::udf::v2::third_party::flatbuffers::