#640: Refactored generic tests for java#643
Open
sgn4sangar wants to merge 13 commits into
Open
Conversation
This reverts commit cf3fcc1.
sgn4sangar
changed the title
tkilias
reviewed
May 27, 2026
| # Create UDFs needed for SetWithEmptyInput tests | ||
| self.query(udf.fixindent(''' | ||
| CREATE java SET SCRIPT | ||
| set_returns_has_empty_input(a double) RETURNS boolean AS |
|
|
||
| self.query(udf.fixindent(''' | ||
| CREATE java SET SCRIPT | ||
| set_emits_has_empty_input(a double) EMITS (x double, y varchar(10)) AS |
|
|
||
|
|
||
| class DynamicInputErrors(_JavaUdfSetup): | ||
| def test_exception_wrong_arg(self): |
Collaborator
There was a problem hiding this comment.
We probably can remove the cases for the other languages because this test only handles a single language
tkilias
reviewed
May 27, 2026
| with self.assertRaisesRegex(Exception, err_text[self.LANG]): | ||
| self.query('''select fn1.wrong_arg('a') from dual''') | ||
|
|
||
| def test_exception_wrong_operation(self): |
Collaborator
There was a problem hiding this comment.
We probably can remove the cases for the other languages because this test only handles a single language
tkilias
reviewed
May 27, 2026
| self.query('CREATE SCHEMA FN1') | ||
| self.query('OPEN SCHEMA FN1') | ||
| self.query(udf.fixindent(''' | ||
| CREATE java SCALAR SCRIPT dob_1i_1o(x double) |
tkilias
reviewed
May 27, 2026
| ''')) | ||
| self.query(udf.fixindent(''' | ||
| CREATE java SCALAR SCRIPT line_1i_1o(x double) | ||
| EMITS (y double) AS |
Collaborator
There was a problem hiding this comment.
I think, this is duplicated
tkilias
reviewed
May 27, 2026
| FROM DUAL''') | ||
| self.assertRowsEqual([(True, True, True)], rows) | ||
|
|
||
| @udf.TestCase.expectedFailureIfLang('r') |
Collaborator
There was a problem hiding this comment.
This shouldn't be needed anymore
tkilias
reviewed
May 27, 2026
| FROM DUAL''') | ||
| self.assertRowsEqual([(True, True, True)], rows) | ||
|
|
||
| @udf.TestCase.expectedFailureIfLang('r') |
Collaborator
There was a problem hiding this comment.
This shouldn't be needed anymore
tkilias
reviewed
May 27, 2026
| FROM DUAL''') | ||
| self.assertRowsEqual([(True, True, True, True)], rows) | ||
|
|
||
| @udf.TestCase.expectedFailureIfLang('r') |
Collaborator
There was a problem hiding this comment.
This shouldn't be needed anymore
tkilias
reviewed
May 27, 2026
| foo_conn.query('IMPORT FROM SCRIPT fn1.impal_use_connection_fooconn') | ||
| self.query('drop user foo cascade') | ||
|
|
||
| @skip("IMPORT FROM SCRIPT cannot be used in view definitions") |
Collaborator
There was a problem hiding this comment.
This is actually a test for the DB, we probably can remove it
tkilias
reviewed
May 27, 2026
| self.assertRowEqual(('GET_SCRIPT_NAME',), rows[0]) | ||
|
|
||
| def test_script_schema(self): | ||
| if (udf.opts.is_compat_mode != "true"): |
Collaborator
There was a problem hiding this comment.
This something we need to investigate @sgn4sangar this is a comment for me
tkilias
reviewed
May 27, 2026
| from exasol_python_test_framework import udf | ||
|
|
||
|
|
||
| class Test(udf.TestCase): |
Collaborator
There was a problem hiding this comment.
We need to check if this is complete
tkilias
reviewed
May 27, 2026
|
|
||
| locale.setlocale(locale.LC_ALL, 'en_US.UTF-8') | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
We probably don't need this for java
tkilias
reviewed
May 27, 2026
|
|
||
| class UnicodeData(_JavaUdfSetup): | ||
|
|
||
| # @udf.TestCase.expectedFailureIfLang('lua') |
tkilias
reviewed
May 27, 2026
| ''') | ||
| self.assertRowsEqual([], rows) | ||
|
|
||
| @udf.TestCase.expectedFailureIfLang('lua') |
tkilias
reviewed
May 27, 2026
| parser.add_argument('--server', help='connection string') | ||
| parser.add_argument('--script-languages', help='definition of the SCRIPT_LANGUAGES variable') | ||
| opts, _unknown = parser.parse_known_args() | ||
| setattr(udf, 'pythonVersionInUdf', getPythonVersionInUDFs(opts.server, opts.script_languages)) |
Collaborator
There was a problem hiding this comment.
We probably don't need this
tkilias
reviewed
May 27, 2026
|
|
||
| from exasol_python_test_framework import udf | ||
|
|
||
| udf.pythonVersionInUdf = -1 |
Collaborator
There was a problem hiding this comment.
Can be probably we removed
tkilias
reviewed
May 27, 2026
| ] | ||
|
|
||
| @useData(data) | ||
| def test_vectorsize(self, size): |
Collaborator
There was a problem hiding this comment.
We can probably simplify this, because we know we only run java here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #640
generic tests for java alone
this branch is branched out from refactor/640_bring_db_obs_in_gen_lang_tests