#1456: Cleaned up and refactored exaudfclient cc by sgn4sangar · Pull Request #642 · exasol/script-languages

sgn4sangar · 2026-05-25T17:34:06Z

relates to #1456

tomuben · 2026-05-26T09:05:23Z

+#ifdef ENABLE_JAVA_VM
+#include "javacontainer/javacontainer_builder.h"
+#endif //ENABLE_JAVA_VM
+
+#ifdef ENABLE_PYTHON_VM
+#include "python/pythoncontainer.h"
+#endif //ENABLE_PYTHON_VM
+
+#ifdef UDF_PLUGIN_CLIENT
+#include "protegrityclient.h"
+#endif //UDF_PLUGIN_CLIENT
+
+#ifdef ENABLE_STREAMING_VM
+#include "streaming_container/streamingcontainer.h"
+#endif
+
+#ifdef ENABLE_BENCHMARK_VM
+#include "benchmark_container/benchmark_container.h"
+#endif


Can be moved into exaudfclient/exa_vm_factory.cc

tkilias · 2026-05-26T22:27:28Z

+        if((error = dlerror()) != nullptr) {
+            std::stringstream sb;
+            sb << "Error when trying to load symbol '" << symbol_name << "': " << error;
+            fprintf(stderr, "dlsym error: %s loading symbol %s\n", error, sb.str().c_str());


We already using streams for constructing sb, so we probably can also use cerr directly and don't need the string stream and the fprintf

tkilias · 2026-05-26T22:28:18Z

+
+    void* handle = dlmopen(LM_ID_NEWLM, stdLibPath.c_str(), RTLD_NOW);
+    if (!handle) {
+        fprintf(stderr, "dlmopen error: %s; while loading %s\n", dlerror(), stdLibPath.c_str());


We probably could move this also to cerr

tkilias · 2026-05-26T22:29:47Z

+
+void setup_environment() {
+    if (::setenv("HOME", "/tmp", 1) == -1) {
+        fprintf(stderr, "Failed setting HOME env var: %s\n", std::strerror(errno));


We probably move this also to cerr

tkilias · 2026-05-26T22:31:50Z

+    DBGVAR(std::cerr, libexaudflibPath);
+    void* handle = exa_load_libary(libexaudflibPath);
+    if (!handle) {
+        fprintf(stderr, "Failed to load library: %s\n", libexaudflibPath.c_str());


We are already using cerr, so we probably can use it here, too

tkilias · 2026-05-26T22:38:53Z

+#endif
+}
+
+int main(int argc, char **argv) {


A good part of the main is also shared between the languages. The main difference will be in the argument and how the VM is created. Maybe we could also extract the remaining logic into a abstract class which provides abstract methods for usage, validate_arguments and create_vm. Validate arguments would store the parsed arguments in private attributes in the subclasses and create_vm would read the arguments from there again. This makes splitting the languages later easier.

tkilias · 2026-05-26T22:41:03Z

+#include "exa_lib_loader.h"
+#include "utils/debug_message.h"
+
+void* exa_load_libary(const std::string& stdLibPath) {


This is good to have also for the new client later, because there we will need to load libraries into an extra namespace, too.

tkilias · 2026-05-26T22:41:49Z

+    return handle;
+}
+
+void* exa_load_symbol(void *handle, const std::string& symbol_name) {


This is good to have also for the new client later, because there we will need to load libraries into an extra namespace, too.

tkilias · 2026-05-26T22:43:15Z

+
+#include "exa_set_env.h"
+
+void setup_environment() {


This is good to have also for the new client later, because it will also need to setup the environment. We might actually need to move later even more into this function.

tkilias · 2026-05-26T22:45:02Z

+        exit(EXIT_FAILURE);
+    }
+    std::string libexaudflibPath;
+#ifdef CUSTOM_LIBEXAUDFLIB_PATH


Maybe we should move the ifdef into its own function, this would make this function easier to read

tkilias · 2026-05-26T22:47:04Z

+#include <functional>
+#include "exa_vm_factory.h"
+
+std::function<SWIGVMContainers::SWIGVM*()> create_vm(const std::string& argv_lang, bool use_ctpg_options_parser) {


For split of the languages we need a function for every language that returns the lambda. Maybe we extract a function for each language into a separate file and compose them here again, with the ifdef and argument check.

tomuben · 2026-05-27T17:07:41Z

+
+    mb_useCtpgParser = false;
+    if(argc == 4) {
+        mb_useCtpgParser = is_use_ctpg_parser(argv[3]);


This introduces a bug: If there is no fourth CLI parameter, the environment variable SCRIPT_OPTIONS_PARSER_VERSION is never eveluated!

tomuben · 2026-05-27T17:08:36Z

+
+//  Parser option 2 means use ctpg parser.
+//  argv_parser_option is command line argument as it is
+bool ExaUdfClientBase::is_use_ctpg_parser(const std::string& argv_parser_option) {


is_use_ctpg_parser is a strange name. Maybe just use_ctpg_parser?

tomuben · 2026-05-27T17:11:05Z

+#endif //ENABLE_PYTHON_VM
+
+void ExaUdfClientPython::usage(const std::string& programName) {
+    std::cerr   << "Usage: " << programName << " <socket> lang=python <scriptOptionsParserVersion=1|2>"


scriptOptionsParserVersion is actually only relevant for Java

tomuben · 2026-05-27T17:15:57Z

+    Benchmark
+};
+
+class ExaUdfClientBase {


Does it make sense that the base class knows the CLI parameters of each subclass?
Wouldn't it be better if the subclass pass the expected CLI parameters in the constructor to ExaUdfClientBase?
So for example

ExaUdfClientPython::ExaUdfClientPython() : ExaUdfClientBase({"lang=python"})...

?

or there could be a pure virtual function which returns the list of expected CLI parameters, which each subclass implements.

I think, each subclas should implement it own validate_cli_argiments or maybe better parse_cli_args and store the result as attributes in the object

tkilias · 2026-05-27T21:33:12Z

+
+        setup_environment();
+        std::function<SWIGVMContainers::SWIGVM*()> vmMaker;
+        switch(m_lang) {


The Base class should be an abstract class and call here create_vm, however don't implement it. You mixed implementation of the client that supports all languages with the implementation of the abstract class. For the moment, we need the ExaudfclientBase as abstract class, ExaudfclientAllLangs, and we can add for each language its Exaudfclient{Lang} if we want to, however I would wait with later until we do the split into repos.

tkilias

Accidentally approved, please see my comments

sgn4sangar added 4 commits May 25, 2026 12:23

removed the commented out and dead codes

b563112

refactoring phase-1

2d5a777

adding the parse options for java vm

ef49152

ah.. one more missing piece

5fe2ffd

tomuben reviewed May 26, 2026

View reviewed changes

tkilias reviewed May 26, 2026

View reviewed changes

reorganizing as per comments

2e800a6

tomuben reviewed May 27, 2026

View reviewed changes

tkilias approved these changes May 27, 2026

View reviewed changes

tkilias requested changes May 27, 2026

View reviewed changes


		#include "exa_set_env.h"

		void setup_environment() {

Conversation

sgn4sangar commented May 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkilias May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomuben May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomuben May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkilias left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tkilias May 26, 2026 •

edited

Loading

tomuben May 27, 2026 •

edited

Loading

tomuben May 27, 2026 •

edited

Loading