#168 - Fixed hyphen in a secret problem - #174
Merged
Merged
Conversation
# Conflicts: # exasol/python_extension_common/deployment/language_container_deployer.py # exasol/python_extension_common/deployment/language_container_deployer_cli.py # pyproject.toml # test/unit/deployment/test_language_container_deployer.py # test/unit/deployment/test_language_container_deployer_cli.py
ahsimb
requested a deployment
to
manual-approval
September 7, 2026 16:04 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
ahsimb
had a problem deploying
to
manual-approval
September 7, 2026 16:04 — with
GitHub Actions
Error
GitHub Actions
Error
ahsimb
requested a deployment
to
manual-approval
September 7, 2026 16:08 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ahsimb
requested a deployment
to
manual-approval
September 7, 2026 16:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ahsimb
requested a deployment
to
manual-approval
September 7, 2026 16:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
tkilias
reviewed
Sep 8, 2026
tkilias
reviewed
Sep 10, 2026
| ], | ||
| ) | ||
| def test_encode_decode_secret_value_roundtrip(value): | ||
| assert decode_secret_value(encode_secret_value(value)) == value |
Collaborator
There was a problem hiding this comment.
this only shows that encode decode are compatible but doesnt show that encode escapes as expected
tkilias
approved these changes
Sep 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #168
closes #173