Open
Conversation
Member
I like that idea. Please have a look at how I've updated |
axic
reviewed
May 28, 2019
axic
force-pushed
the
empty-account
branch
2 times, most recently
from
64ec5a7 to
0f92c10
Compare
axic
reviewed
May 28, 2019
|
|
||
| mod native { | ||
| extern "C" { | ||
| pub fn experimental_isAccountEmpty(addressOffset: *const u32) -> u32; |
Member
There was a problem hiding this comment.
Should this be under experimental namespace in the EEI? I think this particular one is under ethereum, just this whole file would collect the non-final methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: ewasm/design#138, axic/runevm#18, ewasm/hera#539
Alternatively this method could be added as part of an "experimental" namespace.