Repository navigation
feat(da): sign blob submissions and broadcast over consensus gRPC #3483
+4,578
−98
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ import ( | |
| "github.com/evstack/ev-node/block" | ||
| "github.com/evstack/ev-node/core/execution" | ||
| coresequencer "github.com/evstack/ev-node/core/sequencer" | ||
| "github.com/evstack/ev-node/da/celestia" | ||
| "github.com/evstack/ev-node/execution/evm" | ||
| "github.com/evstack/ev-node/node" | ||
| rollcmd "github.com/evstack/ev-node/pkg/cmd" | ||
|
|
@@ -59,14 +60,28 @@ var RunCmd = &cobra.Command{ | |
| return err | ||
| } | ||
|
|
||
| var daOpts []block.DAClientOption | ||
| if nodeConfig.DA.TxSigner.Enabled && (nodeConfig.Node.Aggregator || nodeConfig.Node.Promotable) { | ||
|
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/bin/bash
# Inspect the force-inclusion constructor and submission path on the PR branch.
rg -n -C 8 'func NewForceInclusionServer\(|daClient\.Submit\(|Node\.(Aggregator|Promotable)' apps/evm/server/force_inclusion.goRepository: evstack/ev-node Length of output: 1242 🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- apps/evm/cmd/run.go relevant declarations and wiring ---'
rg -n -C 14 -F -e 'nodeConfig.DA.TxSigner.Enabled' -e 'NewForceInclusionServer(' -e 'forceInclusion' -e 'ForceInclusion' apps/evm/cmd/run.go || true
printf '%s\n' '--- force-inclusion constructor and handler context ---'
sed -n '1,95p' apps/evm/server/force_inclusion.go
sed -n '215,265p' apps/evm/server/force_inclusion.go
printf '%s\n' '--- force-inclusion configuration references ---'
rg -n -C 6 -F -e 'ForceInclusion' -e 'force-inclusion' -e 'force_inclusion' apps/evm | head -240 || trueRepository: evstack/ev-node Length of output: 24703 🏁 Script executed: sed -n '1,110p' apps/evm/server/force_inclusion.go; printf '\n--- run wiring ---\n'; rg -n -C 18 -F -e 'NewForceInclusionServer(' -e 'TxSigner.Enabled' apps/evm/cmd/run.go || true; printf '\n--- force inclusion references ---\n'; rg -n -C 5 -F -e 'ForceInclusion' -e 'force_inclusion' apps/evm/cmd apps/evm/server || trueRepository: evstack/ev-node Length of output: 32058 Enable signing for force-inclusion submissions. The Include force-inclusion servers in the signer condition, or reject this configuration during startup. 🤖 Prompt for AI Agents
Contributor
Author
There was a problem hiding this comment. This should probably be addressed
Contributor
There was a problem hiding this comment. @damiannolan I’ll plan the fix so force-inclusion submissions use the configured signer on follower nodes too.
You are interacting with an AI system. |
||
| signerCfg, err := celestia.ConfigFromNode(nodeConfig) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| submitter, err := celestia.New(cmd.Context(), signerCfg, logger) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create DA tx signer: %w", err) | ||
| } | ||
| defer submitter.Close() | ||
| daOpts = append(daOpts, block.WithSubmitter(submitter)) | ||
| } | ||
|
|
||
| var daClient block.FullDAClient | ||
| if nodeConfig.DAEnabled() { | ||
| blobClient, err := blobrpc.NewWSClient(cmd.Context(), logger, nodeConfig.GetDAAddress(), nodeConfig.DA.AuthToken, "") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create blob client: %w", err) | ||
| } | ||
| defer blobClient.Close() | ||
| daClient = block.NewDAClient(blobClient, nodeConfig, logger, daOpts...) | ||
| } else { | ||
| logger.Info().Msg("DA address is not configured; syncing through P2P only") | ||
| } | ||
|
|
@@ -139,7 +154,7 @@ var RunCmd = &cobra.Command{ | |
| }() | ||
| } | ||
|
|
||
| return rollcmd.StartNode(logger, cmd, executor, sequencer, nodeKey, datastore, nodeConfig, genesis, node.NodeOptions{}, daOpts...) | ||
| }, | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.