Skip to content

fix: broken logo & favicon (assets point to dead evolution-api.com URLs)#30

Open
iscarelli wants to merge 2 commits into
evolution-foundation:mainfrom
iscarelli:fix/manager-logo-dead-assets
Open

fix: broken logo & favicon (assets point to dead evolution-api.com URLs)#30
iscarelli wants to merge 2 commits into
evolution-foundation:mainfrom
iscarelli:fix/manager-logo-dead-assets

Conversation

@iscarelli

@iscarelli iscarelli commented Jun 19, 2026

Copy link
Copy Markdown

Problem

The Manager renders a broken logo and favicon. The UI references its brand
assets from the project's old domain, which now return HTTP 404 after the
rebrand:

  • https://evolution-api.com/files/evo/favicon.svg → 404
  • https://evolution-api.com/files/evo/evolution-logo.svg → 404
  • https://evolution-api.com/files/evo/evolution-logo-white.svg → 404

These are referenced in:

  • index.html (favicon)
  • src/pages/Home.tsx (logo, ×2)
  • src/pages/Login/index.tsx
  • src/pages/Login/LicenseCallback.tsx
  • src/components/sidebar.tsx

Fix

Point all of them to the asset already bundled in the repo
public/assets/images/evolution-logo.png (served by Vite at
/assets/images/evolution-logo.png) — removing the external dependency
entirely. Minimal diff, no new assets, no build changes.

Note

The theme-aware branches (dark → white logo, otherwise → colored) now both
resolve to the same local asset, since only evolution-logo.png exists locally.
A dedicated white variant for the dark theme can be re-added later if desired;
the favicon could also use a dedicated square icon. Kept minimal here to fix the
broken images without guessing at brand assets.

🤖 Generated with Claude Code

Summary by Sourcery

Replace broken external logo and favicon URLs with the locally bundled logo asset across the app.

Bug Fixes:

  • Fix broken logo rendering in the sidebar, home page, and login flows by using a local image asset instead of dead external URLs.
  • Fix broken favicon by pointing it to the local logo image asset served by the app.

The Manager referenced its logo and favicon from
https://evolution-api.com/files/evo/* which now return HTTP 404
after the project's domain rebrand, leaving the logo and favicon
broken in the UI.

Point all references to the asset already bundled in the repo
(public/assets/images/evolution-logo.png), removing the external
dependency. Affected: index.html (favicon), pages/Home.tsx,
pages/Login/index.tsx, pages/Login/LicenseCallback.tsx,
components/sidebar.tsx.

Note: the theme branches now resolve to the same local asset; a
dedicated white variant for the dark theme can be re-added later.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces all external evolution-api.com logo and favicon URLs with a single local bundled image asset, ensuring logos and favicon no longer 404 and removing the external dependency on the old domain.

File-Level Changes

Change Details Files
Update all theme-aware logo usages to reference the local bundled logo asset instead of external SVG URLs.
  • Replace dark/light theme logo URLs with '/assets/images/evolution-logo.png' in sidebar layout component.
  • Update both header and hero logos on the Home page to use the local PNG logo for all themes.
  • Adjust Login and LicenseCallback pages to compute logoSrc from the local PNG asset regardless of theme.
src/components/sidebar.tsx
src/pages/Home.tsx
src/pages/Login/index.tsx
src/pages/Login/LicenseCallback.tsx
Point the favicon link tag to the local bundled logo asset instead of the dead external favicon URL.
  • Change the href in the main HTML template to '/assets/images/evolution-logo.png' so it is served by Vite with the rest of the static assets.
index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Now that both branches of the theme condition resolve to the same /assets/images/evolution-logo.png, you can simplify by removing the ternary and just using a single logoSrc value in each component.
  • Consider centralizing the logo path in a shared constant or config so future changes to branding assets only need to be updated in one place instead of across multiple components.
  • In index.html the favicon is declared with type="image/png" but served from a .png path named evolution-logo.png; if this file is not a square icon, you may want to either introduce a proper square favicon asset or at least rename/adjust the type to better match how browsers will treat it.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Now that both branches of the theme condition resolve to the same `/assets/images/evolution-logo.png`, you can simplify by removing the ternary and just using a single `logoSrc` value in each component.
- Consider centralizing the logo path in a shared constant or config so future changes to branding assets only need to be updated in one place instead of across multiple components.
- In `index.html` the favicon is declared with `type="image/png"` but served from a `.png` path named `evolution-logo.png`; if this file is not a square icon, you may want to either introduce a proper square favicon asset or at least rename/adjust the type to better match how browsers will treat it.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Address review feedback: both theme branches resolved to the same
asset, so the ternary was redundant. Extract the path into a single
shared constant (src/lib/constants.ts) and reference it across the
components, dropping the now-unused useTheme imports.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@iscarelli

Copy link
Copy Markdown
Author

Thanks for the review @sourcery-ai — addressed in the latest commit:

  • Redundant ternary: removed. Both branches resolved to the same asset, so each component now uses a single logoSrc/src value (and the now-unused useTheme imports were dropped).
  • Centralized logo path: extracted into a shared constant LOGO_SRC in src/lib/constants.ts, referenced across sidebar.tsx, Home.tsx, Login/index.tsx and Login/LicenseCallback.tsx, so future branding changes happen in one place.
  • Favicon (square icon): left as-is intentionally. The repo only ships the single non-square evolution-logo.png, so this fix points the favicon at it to stop the 404. Adding a dedicated square favicon asset is best left to the maintainers as a follow-up, since it requires a real brand icon I shouldn't invent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant