fix: broken logo & favicon (assets point to dead evolution-api.com URLs)#30
Open
iscarelli wants to merge 2 commits into
Open
fix: broken logo & favicon (assets point to dead evolution-api.com URLs)#30iscarelli wants to merge 2 commits into
iscarelli wants to merge 2 commits into
Conversation
The Manager referenced its logo and favicon from https://evolution-api.com/files/evo/* which now return HTTP 404 after the project's domain rebrand, leaving the logo and favicon broken in the UI. Point all references to the asset already bundled in the repo (public/assets/images/evolution-logo.png), removing the external dependency. Affected: index.html (favicon), pages/Home.tsx, pages/Login/index.tsx, pages/Login/LicenseCallback.tsx, components/sidebar.tsx. Note: the theme branches now resolve to the same local asset; a dedicated white variant for the dark theme can be re-added later. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces all external evolution-api.com logo and favicon URLs with a single local bundled image asset, ensuring logos and favicon no longer 404 and removing the external dependency on the old domain. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that both branches of the theme condition resolve to the same
/assets/images/evolution-logo.png, you can simplify by removing the ternary and just using a singlelogoSrcvalue in each component. - Consider centralizing the logo path in a shared constant or config so future changes to branding assets only need to be updated in one place instead of across multiple components.
- In
index.htmlthe favicon is declared withtype="image/png"but served from a.pngpath namedevolution-logo.png; if this file is not a square icon, you may want to either introduce a proper square favicon asset or at least rename/adjust the type to better match how browsers will treat it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that both branches of the theme condition resolve to the same `/assets/images/evolution-logo.png`, you can simplify by removing the ternary and just using a single `logoSrc` value in each component.
- Consider centralizing the logo path in a shared constant or config so future changes to branding assets only need to be updated in one place instead of across multiple components.
- In `index.html` the favicon is declared with `type="image/png"` but served from a `.png` path named `evolution-logo.png`; if this file is not a square icon, you may want to either introduce a proper square favicon asset or at least rename/adjust the type to better match how browsers will treat it.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Address review feedback: both theme branches resolved to the same asset, so the ternary was redundant. Extract the path into a single shared constant (src/lib/constants.ts) and reference it across the components, dropping the now-unused useTheme imports. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Thanks for the review @sourcery-ai — addressed in the latest commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Manager renders a broken logo and favicon. The UI references its brand
assets from the project's old domain, which now return HTTP 404 after the
rebrand:
https://evolution-api.com/files/evo/favicon.svg→ 404https://evolution-api.com/files/evo/evolution-logo.svg→ 404https://evolution-api.com/files/evo/evolution-logo-white.svg→ 404These are referenced in:
index.html(favicon)src/pages/Home.tsx(logo, ×2)src/pages/Login/index.tsxsrc/pages/Login/LicenseCallback.tsxsrc/components/sidebar.tsxFix
Point all of them to the asset already bundled in the repo —
public/assets/images/evolution-logo.png(served by Vite at/assets/images/evolution-logo.png) — removing the external dependencyentirely. Minimal diff, no new assets, no build changes.
Note
The theme-aware branches (
dark→ white logo, otherwise → colored) now bothresolve to the same local asset, since only
evolution-logo.pngexists locally.A dedicated white variant for the dark theme can be re-added later if desired;
the favicon could also use a dedicated square icon. Kept minimal here to fix the
broken images without guessing at brand assets.
🤖 Generated with Claude Code
Summary by Sourcery
Replace broken external logo and favicon URLs with the locally bundled logo asset across the app.
Bug Fixes: