fix: reuse cached group metadata before sends - #2681
Open
oscarmtz1311 wants to merge 1 commit into
Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReuse existing WhatsApp group metadata cache instead of performing an extra round-trip before group sends, while preserving cache-miss behavior. Sequence diagram for WhatsApp group resolution using cached metadatasequenceDiagram
participant BaileysStartupService
participant GroupMetadataCache
loop jids_groups
BaileysStartupService->>GroupMetadataCache: getGroupMetadataCache(jid)
alt [cache hit]
BaileysStartupService-->>BaileysStartupService: new OnWhatsAppDto(jid, true, number)
else [cache miss]
BaileysStartupService-->>BaileysStartupService: new OnWhatsAppDto(jid, false, number)
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the groups resolution path, replacing
findGroup({ groupJid: jid }, 'inner')withgetGroupMetadataCache(jid)changes behavior on cache misses; consider adding a fallback to the previous resolution logic (or explicitly ensuring cache population before this call) to avoid false negatives when metadata isn't yet cached.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the groups resolution path, replacing `findGroup({ groupJid: jid }, 'inner')` with `getGroupMetadataCache(jid)` changes behavior on cache misses; consider adding a fallback to the previous resolution logic (or explicitly ensuring cache population before this call) to avoid false negatives when metadata isn't yet cached.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- reuse the existing group metadata cache during WhatsApp group resolution\n- remove the redundant groupMetadata round-trip before group sends\n- preserve existing cache-miss validation and cache population behavior\n\n## Validation\n- npm run db:generate\n- npm run build\n- npm run lint:check -- --no-fix\n- targeted group-cache guard and git diff --check
Summary by Sourcery
Bug Fixes: