1/15 wsprintfA: cap output and width, consume unhandled args - #2
Open
avanturist888 wants to merge 1 commit into
Open
1/15 wsprintfA: cap output and width, consume unhandled args#2avanturist888 wants to merge 1 commit into
avanturist888 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs in
wsprintfA, which came in with my earlier commit, so these are mine to fix:%sruns past the caller's buffer into whatever follows it.usizethat then sizes an allocation here, so%2000000000dasks for 2GB of padding, andwidth * 10overflows on a long enough digit run.%fbut did not consume its argument, so every argument after it read the wrong stack slot.wsprintfA(buf, "%f fps in %s", flt, name)makes%streat the float's low dword as a pointer.First of the small PRs replacing #1, per the discussion there.