Add mounted API route aliases - #178
Conversation
Expose canonical Thingifier routes through named public mounts, including mount-aware runtime routing, Location header rewriting, documentation projection, and callback/validator path context. Also project generated mounted operation text to public paths for issue 177.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 327a1f54b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!hasDocumentedMounts()) { | ||
| return routingDefinition; |
There was a problem hiding this comment.
When every configured mount uses hideFromDocs(), this returns the unmounted canonical definitions, and when visible mounts coexist, the loop similarly omits each hidden mount. ThingifierHttpApiRoutings registers server endpoints from these same generated definitions, so a hidden mount such as /legacy is not callable over the actual HTTP server despite hideFromDocs() promising to affect documentation only; retain projected routes with hiddenFromDocumentation metadata so Swagger can omit them without dropping server registration.
Useful? React with 👍 / 👎.
| @Test | ||
| void mountedFixedRouteUsesInternalTargetAndCallbackSeesPublicPath() { |
There was a problem hiding this comment.
This test combines fixed-route resolution and response behavior with the independent callback mount-path contract, as reflected by the And in its name and the separate status/body, path, mount, and identifier assertions. Split these behaviors so a routing failure does not obscure which callback-context guarantee broke.
AGENTS.md reference: AGENTS.md:L6-L15
Useful? React with 👍 / 👎.
Summary
Verification
Closes #176
Closes #177