Repository navigation
Conversation
Lock the top-level Skill contract, Doctor failure when it is missing, and the best-effort CLI behavior recommendation. Mark the phase-skill repair skip as an expected failure. Co-authored-by: 叁則 <2522048902@qq.com>
Keep sessionStart aligned with the plan-package contract and lock delete, notebook, rm, tee, and absolute redirect guards that the existing hook tests do not execute. Co-authored-by: 叁則 <2522048902@qq.com>
Lock handoff and active-plan disagreement, occupied history slots, and provenance plan_version conflicts. Mark non-object active_plan finalize as an expected failure. Co-authored-by: 叁則 <2522048902@qq.com>
Mark the empty-smoke placeholder and the raw cursor host id in the zh-CN success summary as expected failures. Co-authored-by: 叁則 <2522048902@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题清单
按严重程度排列。每条都有对应测试，CI 用
pytest.mark.xfail(strict=True)保持绿色。AUDIT-1｜中｜
installer/cursor_plugin.py:51-67｜完成一次 Cursor 安装后，把已安装的.cursor/skills/sopify/analyze/SKILL.md改成与源码树不同的内容，再对同一 home 重跑安装。｜预期：重写该阶段 Skill，action 不是skipped。实际：install_cursor_user_plugin_assets返回skipped，截断内容还在；同一条件下run_install的 host 与 payload 也都是skipped。｜tests/test_cursor_cli_install_surface.py::CursorCliInstallSurfaceTests::test_reinstall_restores_phase_skill_that_differs_from_source｜确认AUDIT-2｜低｜
installer/distribution.py:848（简体中文摘要在676-677行打印）｜对空 home 执行cursor:zh-CN安装并渲染默认用户摘要。｜预期：成功摘要不把「没跑 smoke」显示成英文占位。实际：诊断行是(no smoke output)。传入以Runtime smoke check passed开头的输出时，中文译文「运行时自检已通过。」是正常的。｜tests/test_install_user_summary.py::InstallUserSummaryTests::test_success_summary_does_not_print_empty_smoke_placeholder｜确认AUDIT-3｜低｜
installer/distribution.py:900-906（摘要用在647行）｜渲染cursor:zh-CN的默认用户摘要。｜预期：下一步写成「打开 Cursor」，和其他宿主一样用产品名。实际：_host_display_name没有 cursor，句子是「在目标仓库中打开 cursor」，上一行则是「重启 Cursor」。｜tests/test_install_user_summary.py::InstallUserSummaryTests::test_cursor_summary_uses_the_product_display_name｜确认AUDIT-4｜低｜
sopify_writer/store.py:321，读取在sopify_writer/io.py:18｜把state/active_plan.json写成 JSON 数组[]，再finalize_plan。｜预期：抛出InvariantViolationError，不归档。实际：read_json原样返回数组，finalize_plan对它调用.get，抛出AttributeError；方案目录仍在。空对象{}会走协议错误，不在这条里。｜tests/test_sopify_writer_state_guards.py::ProtocolStoreStateGuardTests::test_finalize_rejects_non_object_active_plan｜确认全量
python3 -m pytest tests -q：333 passed，4 xfailed，88 subtests passed。