fix: reduce skipped spec tests, implement cut/tr features (#309, #314)#391
Merged
fix: reduce skipped spec tests, implement cut/tr features (#309, #314)#391
Conversation
Word-split (25→10 skips): fix $*/$@ with IFS, set positional params,
"$*" join with IFS first char, empty/unset IFS distinction, bracket
word parsing for ["$*"], quoted assignment values.
Parse-errors (11→6 skips): bad substitution ${%} detection, export/local
var name validation, for-loop var name validation.
Quote (2→0 skips): empty string preservation, adjacent single-quoted
string joining.
Also fix set -euo pipefail regression (combined -o flag handling).
https://claude.ai/code/session_01QbjrsMFJbHy5XfHCzA6TjM
…314) Add cut character mode (-c/-b), complement (--complement), output delimiter, only-delimited (-s), zero-terminated (-z). Add tr squeeze (-s), complement (-c/-C), and character classes [:lower:], [:upper:], [:digit:], [:alpha:], [:alnum:], [:space:], [:blank:], [:punct:]. Add 30+ new spec tests for cut/tr features. https://claude.ai/code/session_01QbjrsMFJbHy5XfHCzA6TjM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$*/$@,setbuiltin positional params, parse error detection, and variable name validationcut -c/-b,--complement,--output-delimiter,-s,-z;tr -s/-c/-Cand character classes ([:lower:],[:upper:],[:digit:],[:alpha:],[:alnum:],[:space:],[:blank:],[:punct:])Test plan
cargo test --all-featurespasses (all spec tests, comparison tests, unit tests)cargo fmt --checkcleancargo clippy --all-targets --all-features -- -D warningscleanCloses #309 (partially), closes #314