feat(builtins): implement find -exec command execution#386
Merged
Conversation
chaliy
force-pushed
the
claude/fix-320-find-exec-Vvs93
branch
from
d7076a7 to
d626f1c
Compare
Closes #320. The find builtin's -exec flag was parsed but acted like -print because the builtin lacked interpreter access. Now find -exec is intercepted at the interpreter level (like xargs/timeout) so commands are executed via the interpreter for each matched path. Supports both per-file (-exec cmd {} \;) and batch (-exec cmd {} +) modes with {} placeholder substitution. https://claude.ai/code/session_01QbjrsMFJbHy5XfHCzA6TjM
chaliy
force-pushed
the
claude/fix-320-find-exec-Vvs93
branch
from
d626f1c to
b6e7ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #320.
find -execat interpreter level (same pattern as xargs/timeout) so commands execute through the interpreter instead of silently printing pathsfind -exec cmd {} \;) and batch mode (find -exec cmd {} +) with{}placeholder substitutionhas_execfield; makeglob_matchreusable viapub(crate)exportTest plan
test_find_exec_per_file- executes command for each matched filetest_find_exec_batch_mode- executes command once with all pathstest_find_exec_cat_reads_files- verifies actual command execution (cat reads file contents)test_find_exec_with_type_filter- respects -type filter with -exectest_find_exec_nonexistent_path- error handling for missing pathstest_find_exec_no_matches- no execution when nothing matchestest_find_exec_multiple_placeholder- multiple {} in command template