feat(interpreter): implement declare -n nameref variables#255
Merged
Conversation
Add support for name reference variables (namerefs) via `declare -n`. Namerefs allow a variable to act as an alias for another variable name, enabling pass-by-reference semantics in functions. Implementation: - Parse `-n` flag in `execute_declare_builtin` - Store nameref targets as `_NAMEREF_<name>` marker variables - Add `resolve_nameref()` method with chain following (max 10 levels) - Integrate nameref resolution into `expand_variable()` and `set_variable()` Features: - Basic nameref: `declare -n ref=x; echo $ref` reads through ref - Assignment through nameref: `ref=value` sets the target variable - Nameref chains: `declare -n b=a; declare -n c=b; echo $c` - Function parameter passing: `declare -n ref=$1` in functions - Reading through nameref to unset variable returns empty - Target variable changes reflect through nameref Tests: 6 new spec tests (declare.test.sh: 10 → 16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare -nnameref variables that act as aliases for other variable namesresolve_nameref()with chain following (max 10 levels) to prevent infinite loopsChanges
crates/bashkit/src/interpreter/mod.rs: Parse-nflag, store_NAMEREF_<name>markers, addresolve_nameref(), integrate intoexpand_variable()andset_variable()crates/bashkit/tests/spec_cases/bash/declare.test.sh: 6 new spec tests (basic, assign-through, chain, function param, read-unset, reassign-target)specs/009-implementation-status.md: Update test counts (declare 10→16, Bash 887→893, Total 1305→1311)Test plan
cargo test --all-featurespassescargo fmt --checkcleancargo clippy --all-targets --all-features -- -D warningsclean