feat(interpreter): implement set -x xtrace debugging#253
Merged
Conversation
Implement xtrace (set -x) which traces simple commands to stderr before execution. The trace shows expanded argument values prefixed by PS4 (default "+ "). Like real bash, xtrace output goes to the shell's stderr and is not affected by per-command redirections like 2>&1. - Add is_xtrace_enabled() checking both options.xtrace and SHOPT_x - Build trace line in execute_simple_command with expanded args - Prepend trace to ExecResult.stderr after dispatch - 5 spec tests (stdout unaffected by xtrace) + 6 unit tests (stderr content)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -xxtrace which traces simple commands to stderr before execution+)2>&1set +xproperly disables tracing (and is itself traced)Test plan
2>&1does NOT capture xtrace (matching real bash)set +xis traced then disables tracingcargo clippyclean,cargo fmtclean