feat(bash): implement let builtin and fix declare -i arithmetic#250
Merged
feat(bash): implement let builtin and fix declare -i arithmetic#250
Conversation
…valuation `let` builtin evaluates arithmetic expressions with assignment side effects and returns exit code 1 when last expression is zero, 0 otherwise. `declare -i` now uses `evaluate_arithmetic_with_assign` instead of plain `parse().unwrap_or(0)`, so `declare -i x=5+3` correctly yields 8. Adds 11 tests for `let` (basic, multiple, exit codes, increment, compound assign, no-args) and `declare -i` (basic, expressions, variable refs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
letbuiltin for evaluating arithmetic expressions with assignment side effectsdeclare -ito use arithmetic evaluation instead ofparse().unwrap_or(0), sodeclare -i x=5+3correctly yields 8let(basic, multiple, exit codes, increment, compound assign, no-args) anddeclare -i(basic, expressions, variable refs, plain numbers)Test plan
cargo test --all-featurespassescargo clippycleancargo fmt --checkcleanletassignment, exit codes, anddeclare -iarithmetic