feat(bash): case ;& and ;;& fallthrough/continue-matching#249
Merged
Conversation
Add DoubleSemicolon, SemiAmp, and DoubleSemiAmp tokens to the lexer. Parse case terminators into CaseTerminator enum (Break, FallThrough, Continue). Interpreter executes next case body on ;& without pattern check, or continues checking remaining patterns on ;;&. Add 5 spec tests for case fallthrough scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoubleSemicolon,SemiAmp, andDoubleSemiAmptokens to the lexer for proper case terminator parsingCaseTerminatorenum:Break(;;),FallThrough(;&),Continue(;;&);&falls through to next case body unconditionally (without pattern check);;&continues checking remaining case patternsPreviously
;∧;&caused parser fuel exhaustion (infinite loop).Test plan
cargo clippyandcargo fmtclean;;) still pass