fix(bash): nested double quotes inside $() in double-quoted strings#246
Merged
fix(bash): nested double quotes inside $() in double-quoted strings#246
Conversation
The lexer's read_double_quoted_string treated inner `"` inside `$()` as the closing quote, breaking patterns like `echo "$(echo "$x")"`. Add read_command_subst_into() that tracks paren depth and handles nested double/single quotes recursively, supporting arbitrary nesting. Add 8 spec tests for nested quote scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$()command substitutions within double-quoted stringsecho "$(echo "$x")"now correctly expands instead of prematurely closing the outer quotesread_command_subst_into()method that tracks paren depth and handles nested quotes recursivelyTest plan
$(), single quotes, empty strings, multiple substitutions, and escaped characterscargo clippyandcargo fmtclean