fix(bash): BASH_REMATCH not populated when regex starts with parens#242
Merged
fix(bash): BASH_REMATCH not populated when regex starts with parens#242
Conversation
Parser's `parse_conditional` didn't check `saw_regex_op` flag when encountering LeftParen token, so regex patterns starting with capture groups like `([0-9]+)` were parsed as grouping parens instead of being collected as part of the regex pattern. Adds 6 tests covering basic match, multiple groups, nested groups, no-match clearing, and conditional usage. https://claude.ai/code/session_012rzB3FRw7yoQWCG1mxyW7J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan