Merged
Conversation
- Implement ${s/#pat/repl} prefix-anchored and ${s/%pat/repl}
suffix-anchored pattern replacement
- Implement ${var:?"msg"} error expansion with exit code 1
- Handle \/ escape in pattern replacement parsing
- Add read builtin -r flag (raw mode, no backslash interpretation)
and -p flag parsing
- Add 31 new bash spec tests:
- heredoc.test.sh (9): variable expansion, quoted delimiters,
file redirects, command/arithmetic substitution
- string-ops.test.sh (15): prefix/suffix replace, :?, :+,
case conversion, indirect expansion, negative substring
- read-builtin.test.sh (7): IFS splitting, -r flag, here-string
- Bash spec tests: 741 total, 735 pass, 6 skip (100% pass rate)
- Bash comparison: 668/668 match real bash (100%)
https://claude.ai/code/session_012rzB3FRw7yoQWCG1mxyW7J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${s/#pat/repl}prefix-anchored and${s/%pat/repl}suffix-anchored pattern replacement${var:?"msg"}error expansion with exit code 1\/escape in pattern replacement parsingreadbuiltin-rflag (raw mode) and-pflag parsingTest plan
cargo test --all-featurespassescargo clippy --all-targets --all-features -- -D warningscleancargo fmt --checkclean