feat(sed): grouped commands, branching, Q quit, step/zero addresses#227
Merged
feat(sed): grouped commands, branching, Q quit, step/zero addresses#227
Conversation
- Implement {cmd1;cmd2} grouped command blocks with address support
- Add Q (quiet quit) command - exits without printing current line
- Add branch commands: b (unconditional), t (on substitution), :label
- Add step addresses (first~step, e.g. 0~2 for even lines)
- Add 0,/pattern/ addressing (match from start to first occurrence)
- Refactor execution loop: extract exec_sed_cmd helper, track line state
in LineState struct, fix p command to snapshot output immediately
- Remove all 7 sed skip markers - all sed spec tests now pass
- Add 9 new spec tests covering grouped commands, branching, Q, step
addresses, and 0,/pattern/ addressing (positive and negative cases)
- Update specs/009-implementation-status.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{cmd1;cmd2}grouped command blocks with address supportQ(quiet quit),b/t/:labelbranching, step addresses (0~2),0,/pattern/addressingLineStatestruct andexec_sed_cmdhelperTest plan
cargo test --all-features)cargo clippy --all-targets --all-features -- -D warningscleancargo fmt --checkclean