Merged
Conversation
Add incremental output streaming via callbacks for long-running scripts. Interpreter changes: - OutputCallback type: Box<dyn FnMut(&str, &str) + Send + Sync> - Emission points at loop iterations, command lists, sequences, and top-level execute with a dedup counter to prevent double-emission Public API additions: - Bash::exec_streaming() - execute with output callback - ToolStatus::stdout()/stderr() - constructors for output events - ToolStatus.output and .stream fields (optional, backward-compatible) - BashTool::execute_with_status now streams output as ToolStatus events For a script like `for i in 1 2 3; do echo $i; done`, each iteration's output is emitted incrementally via the callback, while the complete result is still returned in ExecResult/ToolResponse. https://claude.ai/code/session_01H1H5WiZVgpjWJ7fTjip51p
… tests - Add streaming_output.rs example showing exec_streaming usage - Add 8 equivalence tests that run same script through exec() and exec_streaming(), asserting identical ExecResult and that concatenated chunks == final stdout/stderr https://claude.ai/code/session_01H1H5WiZVgpjWJ7fTjip51p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec_streamingtoBashandToolDef::invoke_streamingto the tool layer, delivering stdout/stderr incrementally via callbacks while still returning the fullToolResult009-tool-contract.mdwith streaming API documentationstreaming_output.rs) and equivalence tests verifying streamed chunks reassemble to full outputTest plan
cargo test --all-featurespasses (includes streaming equivalence tests)cargo run --example streaming_outputruns end-to-end