feat: per-battery charge/discharge efficiency#99
Open
andig wants to merge 1 commit into
Open
Conversation
Batteries can now carry their own eta_c/eta_d, overriding the top-level values which become defaults for batteries that omit them. The optimizer reads efficiency from BatteryConfig instead of a single global pair. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batteries can now carry their own
eta_c/eta_d. The top-leveleta_c/eta_dbecome defaults applied to batteries that omit them, so existing payloads behave identically.BatteryConfiggainseta_c/eta_d(default 0.95)Optimizerno longer takes globaleta_c/eta_d; SOC constraints read them per batteryapp.pyresolves each battery's efficiency from its own value, falling back to the request-level defaultRefs evcc-io/evcc#32038
🤖 Generated with Claude Code