Skip to content

Fix installed basis.h getting restrictive (0600) permissions #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evaleev wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −4
Open

Fix installed basis.h getting restrictive (0600) permissions #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f9776
Fix installed basis.h getting source file permissions (e.g. 0600)
evaleev May 31, 2026
b575c73
Address review: fix basis.h staged-install DESTDIR + drop CMake 3.19-…
evaleev Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions export/CMakeLists.txt.export
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,14 +785,23 @@ install(
# install basis.h at install time so LIBINT_DATADIR_ABSOLUTE reflects
# any --prefix override. $ENV{DESTDIR} must be prepended manually
# here: install(CODE) runs custom code and does not get the automatic
# DESTDIR handling that install(FILES) etc. have.
# DESTDIR handling that install(FILES) etc. have. configure_file into the
# build tree, then file(COPY) into the install tree with explicit
# FILE_PERMISSIONS so the installed header does not inherit basis.h.in's
# mode (e.g. 0600, which varies by build env); this also works with the
# 3.16 minimum required here, unlike configure_file's NO_SOURCE_PERMISSIONS
# (CMake 3.19+).
install(CODE "
set(LIBINT_VERSION \"${LIBINT_VERSION}\")
set(LIBINT_DATADIR_ABSOLUTE \"\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATADIR}/libint/${LIBINT_VERSION}\")
configure_file(
\"${PROJECT_SOURCE_DIR}/include/libint2/basis.h.in\"
\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${LIBINT2_INSTALL_INCLUDEDIR}/libint2/basis.h\"
\"${PROJECT_BINARY_DIR}/basis.h.install/basis.h\"
@ONLY)
file(COPY
\"${PROJECT_BINARY_DIR}/basis.h.install/basis.h\"
DESTINATION \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${LIBINT2_INSTALL_INCLUDEDIR}/libint2\"
FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ)
")

# install bundled Boost headers if needed
Expand Down
13 changes: 11 additions & 2 deletions src/lib/libint/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,22 @@ else()
)
endforeach()

# generate basis.h at install time so LIBINT_DATADIR_ABSOLUTE reflects any --prefix override
# generate basis.h at install time so LIBINT_DATADIR_ABSOLUTE reflects any --prefix override.
# configure_file into the build tree, then file(COPY) into the install tree with explicit
# FILE_PERMISSIONS: this avoids the installed header inheriting basis.h.in's mode (e.g. 0600,
# which varies by build env) without relying on NO_SOURCE_PERMISSIONS, and prepends
# $ENV{DESTDIR} manually -- install(CODE) runs custom code and does not get the automatic
# DESTDIR handling that install(FILES) etc. have.
install(CODE "
set(LIBINT_VERSION \"${LIBINT_VERSION}\")
set(LIBINT_DATADIR_ABSOLUTE \"\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATADIR}/libint/${LIBINT_VERSION}\")
configure_file(
\"${PROJECT_SOURCE_DIR}/include/libint2/basis.h.in\"
\"\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR}/libint2/basis.h\"
\"${CMAKE_CURRENT_BINARY_DIR}/basis.h.install/basis.h\"
@ONLY)
file(COPY
\"${CMAKE_CURRENT_BINARY_DIR}/basis.h.install/basis.h\"
DESTINATION \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR}/libint2\"
FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ)
")
endif()
Loading