Draft
Conversation
MarcoPolo
force-pushed
the
simnet-example
branch
from
edfc3d5 to
cb93735
Compare
Contributor
|
I think we should have both Shadow and simnet in attsim in a way that we can switch the simulator easily so that we can compare both simulators any time we want, instead of replacing one with the other. |
MarcoPolo
force-pushed
the
simnet-example
branch
from
4b7c75e to
0e8fb77
Compare
Contributor
|
I think it's looking good overall |
useful when debugging and iterating to be sure you're running on the expected changes
Contributor
Author
|
I'm pretty happy with how well this matches with shadow. 100 nodes 200 nodes
For the short term I think it's fine to have both. The work for using both is already done. Long term, I think using the simnet is more flexible and we may craft scenarios that are hard to translate to shadow. But we can cross that bridge when we come to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a bigger change than expected because I also added the gmlparser/shadowconfig/topology.json parser/reader. So that it can use the same files as shadow.
Normally, you wouldn't need all of that because you'd define your network in Go.