test(kademlia): Add synctest to TestAddressBookQuickPrune and remove … #5274
Conversation
akrem-chabchoub
force-pushed
the
migrate-to-synctest-kademlia-flaky
branch
from
634753a to
119231f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors a flaky test by leveraging Go's testing/synctest package to provide deterministic execution for time-dependent test logic, removing the "_FLAKY" suffix from the test name.
- Wraps
TestAddressBookQuickPrune(previouslyTestAddressBookQuickPrune_FLAKY) withsynctest.Testfor deterministic time handling - Removes
t.Parallel()call (incompatible withsynctest.Test) - Adds
testing/synctestimport to support the new testing approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| testutil.CleanupCloser(t, kad) | ||
|
|
||
| time.Sleep(100 * time.Millisecond) | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
When using synctest.Test, real time.Sleep calls should typically be avoided as they defeat the purpose of deterministic time simulation. Consider removing this sleep or verifying if it's necessary with synctest's time control mechanisms.
| time.Sleep(100 * time.Millisecond) | |
| synctest.Advance(t, 100 * time.Millisecond) |
There was a problem hiding this comment.
There is no synctest.Advance in the docs 🙂
martinconic
left a comment
martinconic
left a comment
There was a problem hiding this comment.
Please take a look at failing tests
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):