Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
229 commits
Select commit Hold shift + click to select a range
6e64b11
p2p/discover: add waitForNodes
fjl Aug 29, 2025
29faeee
p2p/discover: add context in waitForNodes
fjl Aug 29, 2025
3c6e404
p2p/discover: move wait condition to lookupIterator
fjl Aug 29, 2025
1c956a1
p2p/discover: improve iterator
fjl Sep 5, 2025
a8fff86
p2p/discover: fix bug in lookup
fjl Sep 5, 2025
af9eb45
p2p/discover: trigger refresh in lookupIterator
fjl Sep 5, 2025
e848f37
p2p/discover: track missing nodes in test
fjl Sep 5, 2025
4d9ed32
p2p/discover: fix two bugs in lookup iterator
fjl Sep 9, 2025
eda3cfb
p2p/discover: remove print in test
fjl Sep 9, 2025
6092898
p2p/discover: add imports in test
fjl Sep 9, 2025
f34a9a9
p2p/discover: clarify lookup behavior on empty table
cskiraly Sep 12, 2025
a974d74
p2p/discover: add test for lookup returning immediately
cskiraly Sep 12, 2025
2b25b2b
Revert "p2p/discover: add test for lookup returning immediately"
cskiraly Sep 12, 2025
60a6847
Update lookup.go
fjl Sep 12, 2025
c3f0e7a
p2p/discover: continue
fjl Sep 12, 2025
1acd3e8
p2p/discover: expose timeout in lookupFailed
cskiraly Sep 16, 2025
9ee23be
revert to using table parameter
cskiraly Sep 17, 2025
0156585
go.mod: update c-kzg (#32639)
MariusVanDerWijden Sep 17, 2025
7b9b0e7
go.mod: update go-eth-kzg (#32640)
MariusVanDerWijden Sep 17, 2025
6ca13c6
core/stateless: add vmwitnessstats cli flag to report leaf stats + lo…
gballet Sep 17, 2025
6db8bf6
triedb/pathdb: generalize the history indexer (#32523)
rjl493456442 Sep 17, 2025
b4682de
trie: add sub-trie iterator support (#32520)
samuelarogbonlo Sep 17, 2025
59c2815
cmd/keeper: disable GC for zkvm execution (#32638)
gballet Sep 17, 2025
7dd6477
core: fix fork readiness log (#32623)
lightclient Sep 18, 2025
98a42fa
core/rawdb: report truncateErr in concurrent truncate failure (#32651)
GarmashAlex Sep 18, 2025
43cd79c
build: update to execution-spec-tests v5.0.0 (#32592)
fjl Sep 18, 2025
375b110
eth/catalyst, beacon/engine: enable BPO and Osaka on stateless APIs (…
rjl493456442 Sep 18, 2025
f170957
eth/filters, cmd: add config of eth_getLogs address limit (#32327)
hlongvu Sep 18, 2025
b253959
beacon/config: fix LoadForks with non-string values (#32609)
klim0v Sep 18, 2025
7f3995d
internal/ethapi: skip tx gas limit check for calls (#32641)
fjl Sep 19, 2025
cfa209b
beacon/blsync: test validated finality (#32633)
zsfelfoldi Sep 19, 2025
0a946fa
core/state: add missing address key in state_object log (#32676)
Galoretka Sep 19, 2025
1c01fae
crypto/bn256: switch to gnark again (#32659)
MariusVanDerWijden Sep 19, 2025
fae2e94
core/txpool/blobpool: remove conversion in GetBlobs (#32578)
cskiraly Sep 19, 2025
d08a2a6
p2p: using testing.B.Loop (#32664)
cuiweixie Sep 19, 2025
e4ce2f5
core/state: using testing.B.Loop (#32658)
cuiweixie Sep 19, 2025
759a617
eth: using testing.B.Loop (#32657)
cuiweixie Sep 19, 2025
bb1ca1c
log: using testing.B.Loop (#32663)
cuiweixie Sep 19, 2025
d6cb8a9
core: using testing.B.Loop (#32662)
cuiweixie Sep 19, 2025
b94e1a6
core/vm: using testing.B.Loop (#32660)
cuiweixie Sep 19, 2025
5765c31
core/types: using testing.B.Loop (#32643)
cuiweixie Sep 19, 2025
b6866b7
crypto: using testing.B.Loop (#32645)
cuiweixie Sep 19, 2025
7915b7d
fix: correct typo in TestMustParseUint64Panic error message (#32648)
CreeptoGengar Sep 19, 2025
18bb7b4
common, eth: remove duplicate test cases (#32624)
zach871 Sep 19, 2025
1c3e5fd
core/rawdb: fix bad blocks sorted failure message to map index→number…
MozirDmitriy Sep 19, 2025
fde18ad
params: update config description links to new format (#32681)
lightclient Sep 20, 2025
066a79b
core/txpool/blobpool: introduce sidecar conversion for legacy blob tr…
rjl493456442 Sep 20, 2025
aa4feba
go.work.sum: add to repo (#32677)
lightclient Sep 20, 2025
3a1c99d
core/state: fix committed-state expectations in StateDB tests (#32678)
GarmashAlex Sep 22, 2025
aa917bb
triedb/pathdb: move head truncation log (#32649)
rjl493456442 Sep 22, 2025
758ad4d
cmd, tests: fix snapshot dump and export-preimages (#32650)
rjl493456442 Sep 22, 2025
062542a
go.work, build: remove workspace file (#32699)
fjl Sep 22, 2025
4cf25a2
cmd/era: fix iterator error source handling in checkAccumulator (#32698)
MozirDmitriy Sep 22, 2025
a31c6a9
cmd/evm/internal/t8ntool: fix nil pointer dereference in Osaka blob g…
bshastry Sep 23, 2025
ce9a091
core/txpool/blobpool: add legacy sidecar conversion in reinject (#32688)
rjl493456442 Sep 23, 2025
dc50e57
accounts/keystore: use runtime.AddCleanup (#32610)
cuiweixie Sep 23, 2025
4b2d3c6
internal/ethapi: fix merge transition in eth_simulate (#32616)
deffrian Sep 23, 2025
22bce45
trie: align AllFFPrefix test assertion and message (#32719)
VolodymyrBg Sep 24, 2025
ec3b989
build: module-aware FindMainPackages (#32736)
fjl Sep 24, 2025
560958f
miner: default gaslimit 60M (#32734)
fjl Sep 24, 2025
f0a6004
core/txpool/blobpool: fork boundary conversion 3 (#32716)
fjl Sep 24, 2025
5921af2
trie: fix TestOneElementProof expected value message (#32738)
radik878 Sep 25, 2025
5c7313c
accounts/keystore: use ticker to avoid timer allocations (#32732)
viktorking7 Sep 25, 2025
af56c78
accounts/abi/bind: fix data race in TestWaitDeployedCornerCases (#32740)
hero5512 Sep 25, 2025
b3d985c
all: add bpo1 and bpo2 overrides (#32737)
lightclient Sep 25, 2025
2e7dc73
core/txpool/blobpool: convert and add one-by-one (#32718)
cskiraly Sep 25, 2025
7b8fdda
build: upgrade to execution-spec-tests v5.1.0 (#32742)
fjl Sep 25, 2025
208c4aa
core/txpool: add eip2681 check for incoming transactions (#32726)
jsvisa Sep 25, 2025
ea52b0c
all: refactor to use builtin max/min (#32694)
cuiweixie Sep 25, 2025
7fa1c99
params: schedule Osaka/BPO1/BPO2 for testnets (#32735)
fjl Sep 25, 2025
80cd449
version: release go-ethereum v1.16.4 stable
fjl Sep 25, 2025
7e84078
version: begin v1.16.5 release cycle
fjl Sep 26, 2025
041403d
internal/ethapi: fix outdated comments (#32751)
wit765 Sep 26, 2025
344c023
ethapi: reject oversize storage keys before hex decode (#32750)
MatusKysel Sep 26, 2025
1d7830d
signer/core: fix TestSignTx to decode res2 (#32749)
VolodymyrBg Sep 26, 2025
1bbcf77
trie: correct error messages for UpdateStorage operations (#32746)
MozirDmitriy Sep 26, 2025
1c5ae75
eth/tracers/native: add keccak256preimage tracer (#32569)
draganm Sep 26, 2025
430f657
params: add amsterdam fork config (#32687)
MariusVanDerWijden Sep 26, 2025
455369e
build: remove duplicated func FileExist (#32768)
cuiweixie Sep 29, 2025
faf987a
eth/catalyst: check osaka in engine_getBlobsV1 (#32731)
jsvisa Sep 29, 2025
ef13254
trie: fix error message in test (#32772)
VolodymyrBg Sep 29, 2025
69b9b72
internal/ethapi: remove redundant check in test (#32760)
GarmashAlex Sep 29, 2025
0c1ac59
cmd/evm/internal/t8ntool: panic on database corruption (#32776)
CPerezz Sep 29, 2025
079960a
params: fix bpo config comments (#32755)
lightclient Sep 29, 2025
e8dd5a3
core/rawdb: update comments (#32668)
VolodymyrBg Sep 29, 2025
7cf17ed
params: implement String() method for ChainConfig (#32766)
futreall Sep 29, 2025
c0638cf
params: add blob config information in the banner (#32771)
rjl493456442 Sep 30, 2025
53dc2db
core/txpool: remove unused signer field from TxPool (#32787)
MozirDmitriy Sep 30, 2025
4c65d03
core/state: correct expected value in TestMessageCallGas (#32780)
Galoretka Sep 30, 2025
63cab20
go.mod, cmd/keeper/go.mod: upgrade victoria metrics dependency (#32720)
gballet Sep 30, 2025
7a7bab7
eth/catalyst: extend payloadVersion support to osaka/post-osaka forks…
yysung1123 Sep 30, 2025
3c03458
p2p: fix error message in test (#32804)
zach871 Sep 30, 2025
656ae02
signer/core: fix error message in test (#32807)
zach871 Sep 30, 2025
4ce18a9
params: fix banner message (#32796)
zach871 Sep 30, 2025
e4da48c
core/types, trie: reduce allocations in derivesha (#30747)
holiman Oct 1, 2025
3295669
p2p/enode: fix discovery AyncFilter deadlock on shutdown (#32572)
zzzckck Oct 2, 2025
103861a
core: refactor StateProcessor to accept ChainContext interface (#32739)
hero5512 Oct 2, 2025
af61ba8
p2p/enode: fix asyncfilter comment (#32823)
cskiraly Oct 2, 2025
862f0fb
trie: cleaner array concatenation (#32756)
hero5512 Oct 2, 2025
802b36d
internal/ethapi: add timestamp to logs in eth_simulate (#32831)
deffrian Oct 6, 2025
db8ef2d
build: faster gh actions workflow, no ubuntu on appveyor (#32829)
s1na Oct 7, 2025
15a0bdd
cmd/devp2p/internal/ethtest: update to PoS-only test chain (#32850)
fjl Oct 8, 2025
be9b32f
core/rawdb: remove duplicated type storedReceiptRLP (#32820)
sashass1315 Oct 8, 2025
6423c7b
eth/protocols/eth: use BlockChain interface in Handshake (#32847)
ngotchac Oct 8, 2025
9761eb0
cmd/devp2p/internal/ethtest: accept responses in any order (#32834)
flcl42 Oct 8, 2025
9dcfdaf
core/rawdb: correct misleading comments for state history accessors (…
phrwlk Oct 9, 2025
d5bc4ab
eth/filters: terminate pending tx subscription on error (#32794)
CertiK-Geth Oct 9, 2025
6190182
eth/filters: add `transactionReceipts` subscription (#32697)
10gic Oct 9, 2025
b34695d
core/txpool/legacypool: fix validTxMeter to count transactions (#32845)
cskiraly Oct 10, 2025
9e7f1ca
eth/protocols/snap: optimize incHash (#32748)
cuiweixie Oct 10, 2025
0764ea6
core/rawdb, triedb/pathdb: introduce trienode history (#32596)
rjl493456442 Oct 10, 2025
6f1d236
ethclient: add SubscribeTransactionReceipts (#32869)
10gic Oct 10, 2025
729484b
node: fix error condition in gzipResponseWriter.init() (#32896)
lukema95 Oct 13, 2025
7403343
core/types: optimize MergeBloom by using bitutil (#32882)
cuiweixie Oct 13, 2025
b7e3cdf
p2p: rm unused var seedMinTableTime (#32876)
jsvisa Oct 13, 2025
85c82d4
eth/filters: uninstall subscription in filter apis on error (#32894)
hyeonLewis Oct 13, 2025
f73f576
triedb, core/rawdb: implement the partial read in freezer (#32132)
jsvisa Oct 13, 2025
b0af5ed
p2p/enode: optimize LogDist (#32887)
cuiweixie Oct 13, 2025
635db50
p2p/enode: optimize DistCmp (#32888)
cuiweixie Oct 13, 2025
59e7da4
core/txpool/legacypool: move queue out of main txpool (#32270)
MariusVanDerWijden Oct 13, 2025
f86ec0c
cmd/workload: filter fuzzer test (#31613)
zsfelfoldi Oct 13, 2025
592c540
p2p/discover: wait for bootstrap to be done (#32881)
jsvisa Oct 13, 2025
b01c3e9
triedb/pathdb: catch int conversion overflow in 32-bit (#32899)
gballet Oct 14, 2025
7fa5365
eth/catalyst: remove useless log on enabling Engine API (#32901)
cskiraly Oct 14, 2025
7dca2e6
eth: do not warn on switching from snap sync to full sync (#32900)
cskiraly Oct 14, 2025
8107de3
core/txpool/legacypool: fix pricedList updates (#32906)
rjl493456442 Oct 14, 2025
2117944
accounts/abi: check presence of payable fallback or receive before pr…
cuiweixie Oct 14, 2025
c42f8f0
internal/ethapi: convert legacy blobtx proofs in sendRawTransaction (…
fjl Oct 14, 2025
d2234e8
rpc: fix flaky test TestServerWebsocketReadLimit (#32889)
mishraa-G Oct 15, 2025
348df9f
eth/protocols/eth: reject message containing duplicated txs and drop …
jsvisa Oct 15, 2025
f4d138e
p2p/discover: remove hot-spin in table refresh trigger (#32912)
fjl Oct 15, 2025
4f5c3f6
version: release go-ethereum v1.16.5 stable
fjl Oct 16, 2025
2f1c600
version: begin v1.16.6 release cycle
fjl Oct 16, 2025
9ba7e2a
cmd/geth: log current key in expandVerkle instead of keylist[0] (#32689)
Galoretka Oct 16, 2025
8aa1683
ethclient: add support for eth_simulateV1 (#32856)
hero5512 Oct 16, 2025
0401194
internal/ethapi: add eth_SendRawTransactionSync (#32830)
aodhgan Oct 16, 2025
e52642d
core/state: state copy bugfixes with Verkle Trees (#31696)
yazzaoui Oct 16, 2025
6fa85f8
eth/ethconfig : fix eth generate config (#32929)
ucwong Oct 17, 2025
bc5f27a
eth, internal: add blob conversion for SendRawTransactionSync (#32930)
rjl493456442 Oct 17, 2025
a6d0a9d
cmd/utils: use maximum uint64 value for receipt chain insertion (#32934)
CertiK-Geth Oct 18, 2025
d2e2383
eth/fetcher: add metrics for tracking slow peers (#32964)
healthykim Oct 20, 2025
72a8a08
eth/fetcher: remove dangling peers from alternates (#32947)
healthykim Oct 20, 2025
5af34cc
triedb/pathdb: fix index out of range panic in decodeSingle (#32937)
hero5512 Oct 20, 2025
4b85736
core/types: prealloc map in HashDifference as in TxDifference (#32946)
cuiweixie Oct 20, 2025
e79261d
eth/filters: avoid rebuild the hash map multi times (#32965)
mask-pp Oct 20, 2025
56f4f2b
core/vm: don't call SetCode after contract creation if initcode didn'…
jwasinger Oct 20, 2025
f0f0294
cmd/keeper: use the ziren keccak precompile (#32816)
gballet Oct 20, 2025
73a2c31
params: enable osaka on dev mode (#32917)
MariusVanDerWijden Oct 20, 2025
ef02d7f
core/txpool: Initialize journal writer for tx tracker (#32921)
KyrinCode Oct 21, 2025
e1d7775
core/state: prevent SetCode hook if contract code is not changed (#32…
rjl493456442 Oct 21, 2025
cb0fd7b
triedb/pathdb: make batch with pre-allocated size (#32914)
rjl493456442 Oct 21, 2025
0241006
cmd/geth: add flag to set genesis (#32844)
lightclient Oct 21, 2025
66e6d4f
core/types: remove unused `ErrInvalidTxType` var (#32989)
cuiweixie Oct 21, 2025
f55c45d
core/state: fix the flaky TestSizeTracker (#32993)
jsvisa Oct 22, 2025
2a2c9c1
cmd/devp2p: distinguish the jwt in devp2p and geth (#32972)
jsvisa Oct 22, 2025
b01111f
p2p: silence on listener shutdown (#33001)
jsvisa Oct 23, 2025
b7d47f7
cmd/utils: use IsHexAddress method (#32997)
mask-pp Oct 23, 2025
4a134fb
crypto: implement ziren keccak state (#32996)
gballet Oct 23, 2025
a4ca207
rpc: fix a flaky test of the websocket (#33002)
jsvisa Oct 23, 2025
8736dc4
eth/tracers: fix crasher in TraceCall with BlockOverrides (#33015)
hero5512 Oct 24, 2025
46de01d
.gitea/workflows, build: add release build for keeper (#32632)
gballet Oct 24, 2025
d96a7b3
build: fix keeper build (#33018)
fjl Oct 24, 2025
38e9a9a
core/rawdb, triedb/pathdb: re-structure the trienode history header (…
rjl493456442 Oct 25, 2025
d34e77f
rpc: remove unused vars (#33012)
rizkyikiw42 Oct 26, 2025
9f6e8b0
core/state: improve accessList copy (#33024)
cuiweixie Oct 26, 2025
72ff167
core: don't modify the shared chainId between tests (#33020)
jsvisa Oct 27, 2025
b556c24
core/types: optimize modernSigner.Equal (#32971)
cuiweixie Oct 27, 2025
dca3820
core: refine condition for using legacy chain freezer directory (#33032)
jsvisa Oct 28, 2025
baeb828
internal/jsre: pass correct args to setTimeout/setInterval callbacks …
anim001k Oct 28, 2025
071a849
.github: add 32-bit CI targets (#32911)
gballet Oct 28, 2025
c726a2f
accounts/abi/bind/v2: fix error assertion in test (#33041)
alarso16 Oct 29, 2025
8376501
p2p: cleanup v4 if v5 failed (#33005)
jsvisa Oct 29, 2025
1b59ef7
common: simplify FileExist helper (#32969)
MamunC0der Oct 30, 2025
9d8ff5a
eth/downloader: fix incorrect waitgroup in test `XTestDelivery` (#33047)
wit765 Oct 30, 2025
55c147e
eth/tracers: fix prestateTracer for EIP-6780 SELFDESTRUCT (#33050)
hero5512 Oct 31, 2025
bd88892
common: fix duration comparison in PrettyAge (#33064)
maradini77 Nov 1, 2025
ad97f83
core/rawdb: fix db inspector by supporting trienode history (#33087)
rjl493456442 Nov 3, 2025
b6e10f4
params: set osaka and BPO1 & BPO2 mainnet dates (#33063)
MariusVanDerWijden Nov 3, 2025
aaa585d
version: release go-ethereum v1.16.6
fjl Nov 3, 2025
9a99e0c
version: begin v1.16.7 release cycle
fjl Nov 3, 2025
3c862f3
go.mod: update to c-kzg v2.1.5 (#33093)
MariusVanDerWijden Nov 4, 2025
82aea44
version: release go-ethereum v1.16.7 stable
fjl Nov 4, 2025
d4d9fad
version: begin v1.16.8 release cycle
fjl Nov 4, 2025
4507767
common: introduce IsHexHash and use it (#32998)
mask-pp Nov 4, 2025
a4b9acd
core/rawdb: fix readOnly mode for database (#33025)
MozirDmitriy Nov 4, 2025
873432c
common: fix size comparison in StorageSize (#33105)
rizkyikiw42 Nov 6, 2025
e72b145
core/state: fix bug about getting stable LogsHash result. (#33082)
mask-pp Nov 7, 2025
f70cd5b
accounts/usbwallet: fix version check in SignTypedMessage (#33113)
rizkyikiw42 Nov 7, 2025
c752ea5
core/vm: remove todo (#33120)
MariusVanDerWijden Nov 7, 2025
1fe3eaa
triedb/pathdb: fix 32-bit integer overflow in history trienode decode…
jsvisa Nov 7, 2025
0b465b6
crypto: validate hash length in no cgo Sign (#33104)
lucia-w Nov 8, 2025
cd45794
consensus/misc/eip4844: expose TargetBlobsPerBlock (#32991)
Tristan-Wilson Nov 10, 2025
1fdba72
eth/catalyst: always reset timer after sealing error (#33146)
sashass1315 Nov 10, 2025
d1d011c
build: add wasm targets for keeper (#33124)
gballet Nov 11, 2025
1e98952
core/state: fixed hooked StateDB handling of `OnCodeChangeV2` (#33148)
maoueh Nov 11, 2025
f67fd7d
core/rawdb: capture open file error and fix resource leak (#33147)
lucia-w Nov 11, 2025
32214de
rpc: avoid unnecessary RST_STREAM, PING frames sent by client (#33122)
michaelkaplan13 Nov 11, 2025
36c2ab4
core: remove unused peek function in insertIterator (#33155)
soniseth0 Nov 12, 2025
03faa98
core/txpool/blobpool: fix benchmarkPoolPending (#33161)
cskiraly Nov 13, 2025
1547bcf
eth/filters: further optimize tx hash map in #32965 (#33108)
MonkeyMarcel Nov 13, 2025
fdb55d3
triedb/pathdb: fix ID assignment in history inspection (#33103)
Forostovec Nov 13, 2025
2cc9396
eth/syncer: advance safe and finalized block (#33038)
jsvisa Nov 13, 2025
64910c1
core: use scheme-aware empty root in flushAlloc (#33168)
Bashmunta Nov 13, 2025
b4de681
accounts/keystore: clear decrypted key after use (#33090)
phrwlk Nov 13, 2025
1312886
graphql: add nil check in Transaction.Type() method (#33184)
oooLowNeoNooo Nov 14, 2025
7fe9645
core/rawdb: return iterator error in findTxInBlockBody (#33188)
radik878 Nov 14, 2025
abc9be9
core/rawdb: delete dead code to avoid more useless AI submissions (#3…
gballet Nov 14, 2025
4fbfa0c
cmd/evm/internal/t8ntool, trie: support for verkle-at-genesis, use UB…
gballet Nov 14, 2025
6f44b29
ethapi: deref gasUsed pointer in eth_simulate log (#33192)
davidjsonn Nov 15, 2025
05c26af
eth: fix panic in randomDuration when min equals max (#33193)
maradini77 Nov 18, 2025
38cb879
core: initialize tracer before DAO fork logic (#33214)
wit765 Nov 19, 2025
fb72d88
cmd/utils: make datadir.minfreedisk an IntFlag (#33252)
phrwlk Nov 24, 2025
333f308
core, cmd: removed tablewriter from the dependencies (#33218)
cedrickah Nov 24, 2025
3680ece
eth/catalyst: remove the outdated comments of ForkchoiceUpdatedV1 (#3…
georgehao Nov 24, 2025
906e7c8
consensus/beacon: fix blob gas error message formatting (#33201)
rizkyikiw42 Nov 24, 2025
4730e13
core/txpool/blobpool: drain and signal pending conversion tasks on sh…
sashass1315 Nov 25, 2025
9b96714
core/rawdb: fix underflow in freezer inspect for empty ancients (#33203)
VolodymyrBg Nov 25, 2025
c913913
cmd/geth: skip resolver for zero-commitment verkle children (#33265)
Bashmunta Nov 25, 2025
ac03551
consensus/misc: fix blob gas error message formatting (#33275)
rizkyikiw42 Nov 26, 2025
99044e5
triedb/pathdb: implement iterator of history index (#32981)
rjl493456442 Nov 26, 2025
3690c9b
beacon: update beacon light client for fusaka (#33272)
zsfelfoldi Nov 26, 2025
bf41c07
rlp: finalize listIterator on parse error to prevent non-advancing lo…
radik878 Nov 26, 2025
8f17a97
accounts/usbwallet: fix double hashing in SignTextWithPassphrase (#33…
lucia-w Nov 26, 2025
8a40666
p2p/discover/v5wire: remove redundant bytes clone in WHOAREYOU encodi…
soniseth0 Nov 26, 2025
cf820ff
miner: add --miner.maxblobs flag (#33129)
MariusVanDerWijden Nov 26, 2025
ad3a93f
core/vm: implement EIP-8024 (#33095)
jrhea Nov 26, 2025
a8d26b2
Update wallet.go
prestoalvarez Nov 26, 2025
f4d3df6
Update wallet.go
prestoalvarez Nov 26, 2025
35c2950
Merge branch 'master' into patch-4
prestoalvarez Nov 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions accounts/usbwallet/wallet.go
Original file line number Diff line number Diff line change
Expand Up @@ -338,14 +338,17 @@
}
// Device lock obtained, derive the next batch of accounts
var (
accs []accounts.Account
paths []accounts.DerivationPath

nextPaths = append([]accounts.DerivationPath{}, w.deriveNextPaths...)
nextAddrs = append([]common.Address{}, w.deriveNextAddrs...)

accs []accounts.Account

Check failure on line 341 in accounts/usbwallet/wallet.go

View workflow job for this annotation

GitHub Actions / Lint

File is not properly formatted (goimports)
paths []accounts.DerivationPath
context = context.Background()
nextAddrs = append([]common.Address{}, w.deriveNextAddrs...)
)
// Deep-copy derivation paths so updates inside this section don't mutate
// w.deriveNextPaths while we only hold stateLock.RLock.
nextPaths := make([]accounts.DerivationPath, len(w.deriveNextPaths))
for i, path := range w.deriveNextPaths {
nextPaths[i] = append(accounts.DerivationPath(nil), path...)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of not updating slices that are aliased to w.deriveNextPaths while holding stateLock.RLock. From reading the current code, it seems like SelfDerive is the only other user of deriveNextPaths and it always runs under stateLock.Lock. I could be wrong, but I’m not seeing an actual concurrent read/write.

Did you hit a -race report in practice, or is this more of a defensive change to avoid future issues?

for i := 0; i < len(nextAddrs); i++ {
for empty := false; !empty; {
// Retrieve the next derived Ethereum account
Expand Down
3 changes: 0 additions & 3 deletions beacon/params/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ ALTAIR_FORK_EPOCH: 1
EIP7928_FORK_VERSION: 0xb0000038
EIP7928_FORK_EPOCH: 18446744073709551615

EIP7XXX_FORK_VERSION:
EIP7XXX_FORK_EPOCH:

BLOB_SCHEDULE: []
`
c := &ChainConfig{}
Expand Down
Loading