Skip to content

Conversation

@xprotocol-bot
Copy link

Hi
We are building a aggregator and as part of the building we use many Go sdk from many chains. Having a conflict between and old and new verison of github.com/olekukonko/tablewriter prevent us from using go-ethereum.
We already create a fork for this and we think it might be suitable to upstream this change.

@xprotocol-bot xprotocol-bot changed the title upgrade github.com/olekukonko/tablewriter core/rawdb, cmd/geth: upgrade github.com/olekukonko/tablewriter Nov 13, 2025
@rjl493456442
Copy link
Member

package main

import (
	"fmt"
	"os"

	"github.com/ethereum/go-ethereum/params"
	"github.com/olekukonko/tablewriter"
)

func main() {
	fmt.Println("Hello World")

	table := tablewriter.NewWriter(os.Stdout)
	_ = table

	fmt.Println(params.MainnetGenesisHash.Hex())
}
module github.com/rjl493456442/gomod-dep

go 1.24.0

require (
	github.com/ethereum/go-ethereum v1.16.7
	github.com/olekukonko/tablewriter v1.1.1
)

require (
	github.com/clipperhouse/displaywidth v0.3.1 // indirect
	github.com/clipperhouse/stringish v0.1.1 // indirect
	github.com/clipperhouse/uax29/v2 v2.2.0 // indirect
	github.com/fatih/color v1.16.0 // indirect
	github.com/holiman/uint256 v1.3.2 // indirect
	github.com/mattn/go-colorable v0.1.13 // indirect
	github.com/mattn/go-isatty v0.0.20 // indirect
	github.com/mattn/go-runewidth v0.0.19 // indirect
	github.com/olekukonko/cat v0.0.0-20250911104152-50322a0618f6 // indirect
	github.com/olekukonko/errors v1.1.0 // indirect
	github.com/olekukonko/ll v0.1.2 // indirect
	golang.org/x/crypto v0.36.0 // indirect
	golang.org/x/sys v0.36.0 // indirect
)

It works for me

@rjl493456442
Copy link
Member

(base) ➜  gomod-dep git:(master) ✗ go run main.go
# github.com/ethereum/go-ethereum/core/rawdb
../../../../pkg/mod/github.com/ethereum/go-ethereum@v1.16.7/core/rawdb/database.go:653:8: table.SetHeader undefined (type *Table has no field or method SetHeader)
../../../../pkg/mod/github.com/ethereum/go-ethereum@v1.16.7/core/rawdb/database.go:654:8: table.SetFooter undefined (type *Table has no field or method SetFooter)
../../../../pkg/mod/github.com/ethereum/go-ethereum@v1.16.7/core/rawdb/database.go:655:8: table.AppendBulk undefined (type *Table has no field or method AppendBulk)

The conflicting indeed exists.

@rjl493456442
Copy link
Member

I will remove it from our dependency, as it's no reason to keep the complexity around just for terminal table printer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants