Skip to content

Conversation

@kidneyhex
Copy link
Contributor

@kidneyhex kidneyhex commented Nov 28, 2025

Closing this: The fix requires design choices, so I'll just log an issue and let someone else decide. :P

@kidneyhex kidneyhex marked this pull request as draft November 28, 2025 05:08
@bobrippling
Copy link
Collaborator

I'll hold off reviewing / testing until this is out of draft, but with it being a core app I'll tag @gfwilliams in the meanwhile

@kidneyhex
Copy link
Contributor Author

kidneyhex commented Nov 28, 2025

The current code is working, but I ran into an app where GadgetBridge isn't sending musicinfo even on play/pause (libro.fm), so the music entry/controls aren't showing up.

If we could just request the info/state, it would simplify things and reduce the need for writing to flash. (I think?)

I see someone else proposed this too (https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/4886), and it wasn't outright rejected, so I might do that this weekend and see if it's accepted, then revise this to use it.

--- I don't have access to an apple device though, so that does complicate things a little.

…sting musicinfo; add settings for expiring old music msg
@bobrippling
Copy link
Collaborator

Cool! For that last bit, you could ask in discussions, I think there's a few iPhone users about

@gfwilliams
Copy link
Member

gfwilliams commented Dec 1, 2025

I'm really not convinced about requesting state (it feels like a hack to work around a bug somewhere) - I've put some more of my thoughts on this on https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/4886#issuecomment-8622057

edit:

I ran into an app where GadgetBridge isn't sending musicinfo even on play/pause (libro.fm)

This is kind of what I mean - we should fix this in Gadgetbridge (or maybe it's a libro.fm issue?), and then it'll help everyone using it (even those without a Bangle.js).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants