fix(ble): Fix Advertising data being overwritten

[lucasssvaz]

Description of Change

This pull request enhances memory management and object copying for the BLEAdvertisedDevice class, ensuring safe handling of the advertising payload buffer. The changes add a destructor, copy constructor, and assignment operator, and improve how the payload buffer is allocated, copied, and freed to avoid memory leaks and ensure correct behavior when objects are copied or reassigned.

Memory management and object lifecycle improvements:

• Added a destructor, copy constructor, and assignment operator to BLEAdvertisedDevice to properly manage the dynamic m_payload buffer, ensuring deep copies and freeing memory when needed. (libraries/BLE/src/BLEAdvertisedDevice.cpp, libraries/BLE/src/BLEAdvertisedDevice.h) [1] [2]
• Modified the constructor to initialize m_payload and m_payloadLength to safe default values. (libraries/BLE/src/BLEAdvertisedDevice.cpp)

Payload buffer handling improvements:

• Updated parseAdvertisement to always make a copy of the payload buffer and to append scan response data safely, preventing use-after-free or double-free issues. (libraries/BLE/src/BLEAdvertisedDevice.cpp)
• Improved setPayload to allocate, copy, and append payload data safely, with error checking and freeing of previous buffers as needed. (libraries/BLE/src/BLEAdvertisedDevice.cpp)

Test Scenarios

Tested locally

Related links

Closes #12075

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 711ccfa

[github-actions]

Test Results

 76 files   76 suites   18m 34s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 711ccfa.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	⚠️ +926	0.00	⚠️ +0.12	0	0	0.00	0.00
ESP32P4	0	⚠️ +928	0.00	⚠️ +0.12	0	0	0.00	0.00
ESP32S3	0	⚠️ +792	0.00	⚠️ +0.13	0	0	0.00	0.00
ESP32C3	0	⚠️ +926	0.00	⚠️ +0.15	0	0	0.00	0.00
ESP32C6	0	⚠️ +930	0.00	⚠️ +0.13	0	0	0.00	0.00
ESP32H2	0	⚠️ +926	0.00	⚠️ +0.13	0	0	0.00	0.00
ESP32	0	⚠️ +844	0.00	⚠️ +0.08	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32P4		ESP32S3		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/BLE/examples/Beacon_Scanner	⚠️ +926	0	⚠️ +928	0	⚠️ +792	0	⚠️ +926	0	⚠️ +930	0	⚠️ +926	0	⚠️ +812	0
libraries/BLE/examples/Client	⚠️ +460	0	⚠️ +464	0	⚠️ +332	0	⚠️ +460	0	⚠️ +462	0	⚠️ +460	0	⚠️ +312	0
libraries/BLE/examples/Client_multiconnect	⚠️ +374	0	⚠️ +370	0	⚠️ +288	0	⚠️ +370	0	⚠️ +374	0	⚠️ +374	0	⚠️ +284	0
libraries/BLE/examples/Client_secure_static_passkey	⚠️ +464	0	⚠️ +464	0	⚠️ +368	0	⚠️ +464	0	⚠️ +466	0	⚠️ +464	0	⚠️ +316	0
libraries/BLE/examples/EddystoneTLM_Beacon	⚠️ +924	0	⚠️ +922	0	⚠️ +784	0	⚠️ +924	0	⚠️ +924	0	⚠️ +924	0	⚠️ +816	0
libraries/BLE/examples/EddystoneURL_Beacon	⚠️ +926	0	⚠️ +924	0	⚠️ +784	0	⚠️ +926	0	⚠️ +924	0	⚠️ +926	0	⚠️ +804	0
libraries/BLE/examples/Notify	⚠️ +912	0	⚠️ +912	0	⚠️ +776	0	⚠️ +914	0	⚠️ +914	0	⚠️ +912	0	⚠️ +804	0
libraries/BLE/examples/Scan	⚠️ +920	0	⚠️ +920	0	⚠️ +788	0	⚠️ +920	0	⚠️ +920	0	⚠️ +920	0	⚠️ +820	0
libraries/BLE/examples/Server	⚠️ +916	0	⚠️ +916	0	⚠️ +780	0	⚠️ +918	0	⚠️ +916	0	⚠️ +916	0	⚠️ +800	0
libraries/BLE/examples/Server_multiconnect	⚠️ +912	0	⚠️ +914	0	⚠️ +776	0	⚠️ +914	0	⚠️ +914	0	⚠️ +912	0	⚠️ +804	0
libraries/BLE/examples/Server_secure_authorization	⚠️ +918	0	-	-	⚠️ +792	0	⚠️ +918	0	⚠️ +918	0	⚠️ +918	0	-	-
libraries/BLE/examples/Server_secure_static_passkey	⚠️ +912	0	⚠️ +914	0	⚠️ +788	0	⚠️ +912	0	⚠️ +912	0	⚠️ +912	0	⚠️ +784	0
libraries/BLE/examples/UART	⚠️ +912	0	⚠️ +914	0	⚠️ +776	0	⚠️ +912	0	⚠️ +912	0	⚠️ +912	0	⚠️ +812	0
libraries/BLE/examples/Write	⚠️ +916	0	⚠️ +916	0	⚠️ +788	0	⚠️ +920	0	⚠️ +916	0	⚠️ +916	0	⚠️ +800	0
libraries/BLE/examples/iBeacon	⚠️ +924	0	⚠️ +924	0	⚠️ +788	0	⚠️ +922	0	⚠️ +924	0	⚠️ +924	0	⚠️ +844	0