-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(littlefs): Adjust log level during formatting #12092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello JakubAndrysek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 15m 11s ⏱️ Results for commit 853a68a. ♻️ This comment has been updated with latest results. |
|
Wokwi is failing on GPIO tests with ESP32c6. I have tested running it multiple times locally with the same commands, and it works. Can you please try to re-run this test? There is probably again a timing problem. |
|
I have tested to run it in my fork and it works: JakubAndrysek#19 |
This pull request introduces a minor but important improvement to the
LittleFSFS::format()method inLittleFS.cpp. The change temporarily suppresses all ESP logging during the filesystem format operation to reduce log noise and then restores the default log level afterwards.ESP_LOG_NONEbefore callingesp_littlefs_format, and restores the previous log level afterwards to minimise unnecessary log output during the format process.Implemented the same as in SPIFFS: https://github.com/espressif/arduino-esp32/blob/3.3.4/libraries/SPIFFS/src/SPIFFS.cpp#L93-L106
Fixes: