Skip to content

Conversation

@JakubAndrysek
Copy link
Collaborator

This pull request introduces a minor but important improvement to the LittleFSFS::format() method in LittleFS.cpp. The change temporarily suppresses all ESP logging during the filesystem format operation to reduce log noise and then restores the default log level afterwards.

  • Logging control during formatting:
    • Suppresses all ESP logs by setting the log level to ESP_LOG_NONE before calling esp_littlefs_format, and restores the previous log level afterwards to minimise unnecessary log output during the format process.

Implemented the same as in SPIFFS: https://github.com/espressif/arduino-esp32/blob/3.3.4/libraries/SPIFFS/src/SPIFFS.cpp#L93-L106

Fixes:

E (15795) esp_littlefs: mount failed,  (-84)
E (15799) esp_littlefs: Failed to initialize LittleFS
E (31716) task_wdt: esp_task_wdt_reset(707): task not found
E (31722) task_wdt: esp_task_wdt_reset(707): task not found
E (31756) task_wdt: esp_task_wdt_reset(707): task not found
E (31757) task_wdt: esp_task_wdt_reset(707): task not found
E (31758) task_wdt: esp_task_wdt_reset(707): task not found
E (31761) task_wdt: esp_task_wdt_reset(707): task not found
E (31796) task_wdt: esp_task_wdt_reset(707): task not found
E (31797) task_wdt: esp_task_wdt_reset(707): task not found
E (31798) task_wdt: esp_task_wdt_reset(707): task not found
E (31801) task_wdt: esp_task_wdt_reset(707): task not found
E (31806) task_wdt: esp_task_wdt_reset(707): task not found

@JakubAndrysek JakubAndrysek requested a review from a team as a code owner December 2, 2025 11:18
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 853a68a

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50⚠️ +360.00⚠️ +0.01000.000.00
ESP32P40⚠️ +360.00⚠️ +0.01000.000.00
ESP32S30⚠️ +240.00⚠️ +0.01000.000.00
ESP32S20⚠️ +240.00⚠️ +0.01000.000.00
ESP32C30⚠️ +360.00⚠️ +0.01000.000.00
ESP32C60⚠️ +380.00⚠️ +0.01000.000.00
ESP32H20⚠️ +360.00⚠️ +0.01000.000.00
ESP320⚠️ +240.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/LittleFS/examples/LITTLEFS_test⚠️ +360⚠️ +360⚠️ +200⚠️ +200⚠️ +360⚠️ +380⚠️ +360⚠️ +200
libraries/LittleFS/examples/LITTLEFS_time⚠️ +360⚠️ +360⚠️ +240⚠️ +240⚠️ +360⚠️ +380--⚠️ +240
libraries/WebServer/examples/WebServer⚠️ +360⚠️ +360⚠️ +160⚠️ +240⚠️ +360⚠️ +360--⚠️ +240

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Test Results

 76 files   76 suites   15m 11s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 853a68a.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Dec 2, 2025
@lucasssvaz
Copy link
Member

@JakubAndrysek
Copy link
Collaborator Author

Wokwi is failing on GPIO tests with ESP32c6. I have tested running it multiple times locally with the same commands, and it works. Can you please try to re-run this test? There is probably again a timing problem.
The weird thing is that this test has been there for a few weeks, and it has worked perfectly.

@JakubAndrysek
Copy link
Collaborator Author

I have tested to run it in my fork and it works: JakubAndrysek#19

@me-no-dev me-no-dev merged commit cd44ed4 into espressif:master Dec 2, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants