refactor(ui)!: remove semantic token bridge - #551
Merged
Conversation
Revision buffers now use Tree-sitter syntax highlighting only. Remove the manual LSP document lifecycle and semantic-token renderer to avoid unsupported codediff:// URIs and server lifecycle failures. BREAKING CHANGE: CodeDiff no longer requests or renders LSP semantic tokens in virtual revision and conflict buffers. LSP behavior for real working-tree buffers is unchanged.
esmuellert
enabled auto-merge
September 6, 2026 03:01
yanuoma
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
didOpen/didClosesemantic-token trafficMotivation
The bridge required CodeDiff to emulate an LSP document lifecycle for
codediff://URIs. It caused duplicatedidOpen, orphandidClose, stale asynchronous responses, unsupported URI errors, and server-specific failures in rust-analyzer, dartls, Astro LSP, marksman, and Terraform LSP.The feature was automatic and had no reliable opt-out. Tree-sitter already provides stable syntax highlighting for virtual buffers, so removing the bridge eliminates this entire failure class and reduces maintenance.
Breaking change
Revision and conflict virtual buffers no longer receive LSP semantic-token highlighting. They use Tree-sitter syntax highlighting instead. Real working-tree buffers retain their normal LSP behavior.
BREAKING CHANGE: CodeDiff no longer requests or renders LSP semantic tokens in virtual revision or conflict buffers.
Closes #476
Closes #297
Closes #403
Issue #140 and #298 were already closed by #259. Issue #392 remains an independent path-handling architecture issue and is not closed by this PR.
Testing
CODEDIFF_TEST_JOBS=2 make test-lua— 106 spec files passedstylua --checkgit diff --check