fix(navigation): handle EOF deletion hunks - #550
Merged
Conversation
esmuellert
enabled auto-merge
September 6, 2026 02:19
yanuoma
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
]c/[cto cross file boundaries when a deletion ends at EOFlua/codediff/ui/view/cursor.luaRoot cause
A deletion at the end of a file is represented by a valid half-open range such as modified
[4, 4)when the modified buffer has only three lines. Navigation treatedstart_line = 4as a cursor row. Neovim rejected that cursor position, the error was swallowed bypcall, and navigation returned success without advancing to the next file.Fix
Cursor placement now converts diff boundary coordinates to valid buffer cursor coordinates before comparing or setting the cursor. This also fixes initial and cross-file landing in both layouts.
Closes #479
Testing
CODEDIFF_TEST_JOBS=2 make test-lua— 107 spec files passedcycle_hunks_across_files_spec.lua— 10 passedstylua --checkgit diff --check