Skip to content

test: cover @page margin properties - #524

Draft
Pixel998 wants to merge 1 commit into
mainfrom
test/page-margin-properties
Draft

test: cover @page margin properties#524
Pixel998 wants to merge 1 commit into
mainfrom
test/page-margin-properties

Conversation

@Pixel998

@Pixel998 Pixel998 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Prevent regressions where valid page-margin declarations are reported as unknown @page descriptors.

What changes did you make? (Give an overview)

Added a no-invalid-at-rules test covering margin, margin-top, margin-right, margin-bottom, and margin-left inside @page.

Related Issues

Closes #519

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Aug 4, 2026
@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Aug 4, 2026

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks. I changed this to "blocked" as this requires csstree update (see PR).

@DMartens DMartens moved this from Implementing to Blocked in Triage Aug 4, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Aug 14, 2026
@Pixel998 Pixel998 added accepted There is consensus among the team that this change meets the criteria for inclusion and removed Stale labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

Bug: no-invalid-at-rules doesn't recognize margin

2 participants