Skip to content

Update the code to better handle the dropdown menus#299

Draft
erwindon wants to merge 1 commit intomasterfrom
dropdown
Draft

Update the code to better handle the dropdown menus#299
erwindon wants to merge 1 commit intomasterfrom
dropdown

Conversation

@erwindon
Copy link
Owner

@erwindon erwindon commented Dec 27, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
The current "checkbox-button" style menu and the "radio-button" style menu's have very dirty implementations.
Both can be found in the command-box.

Describe the solution you'd like
This should be cleaned up. Best solution seems to be the introduction of a "DropDownCheckbox" and "DropDownRadio" sub-classes that handle all the specifics.

Describe alternatives you've considered

  1. Leave it like this.
  2. switch to a gui toolkit that has this available.

Additional context
Additionally, the difference between the user's choice and the system's choice in the "target" menu should be enhanced.

Additionally, the dropdown menu's should work on touchscreens. i.e. the menu opens on 'click' instead of only 'mouseover'.

@erwindon erwindon self-assigned this Aug 11, 2020
@erwindon
Copy link
Owner Author

erwindon commented Oct 16, 2020

User's choice will be marked with ⚫ when present
System default will be marked with ⚪ when no user's choice exists

@erwindon erwindon marked this pull request as draft December 27, 2020 14:24
@erwindon erwindon force-pushed the dropdown branch 3 times, most recently from 90b615f to 12df10f Compare December 28, 2020 23:48
@erwindon erwindon force-pushed the dropdown branch 2 times, most recently from afb9270 to b879cf3 Compare February 13, 2021 11:57
Repository owner deleted a comment from sonarqubecloud bot Aug 13, 2021
Repository owner deleted a comment from sonarqubecloud bot Aug 13, 2021
Repository owner deleted a comment from sonarqubecloud bot Aug 13, 2021
@erwindon erwindon force-pushed the dropdown branch 6 times, most recently from f265dd1 to ed09767 Compare August 22, 2021 12:40
@erwindon erwindon force-pushed the dropdown branch 2 times, most recently from 575dbcd to 8535af0 Compare September 5, 2021 20:07
@erwindon erwindon force-pushed the dropdown branch 3 times, most recently from 4ddea20 to fab499b Compare December 4, 2021 14:27
@erwindon erwindon force-pushed the dropdown branch 5 times, most recently from 2afdd0a to 511c927 Compare December 15, 2021 23:55
@erwindon erwindon force-pushed the dropdown branch 2 times, most recently from 84c9f75 to 27883bf Compare January 2, 2022 17:41
Repository owner deleted a comment from sonarqubecloud bot Mar 7, 2022
@erwindon erwindon force-pushed the dropdown branch 7 times, most recently from e730e72 to e898e44 Compare March 28, 2022 23:14
@erwindon
Copy link
Owner Author

erwindon commented Apr 18, 2022

build completed
TODO: simplify _updateTableFilter to remove sonarcloud issue
TODO: more testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.8% 1.8% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 22, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

1 similar comment
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 23, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@erwindon erwindon

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erwindon