Expand test suite with 10 new tests and fixture plans#60
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 8, 2026
Merged
Conversation
Add test coverage for Rules 25, 28, 30, 31 and parsing improvements (seek predicates, parameter sniffing, PSPO/Dispatcher). Fix Rule 28 Row Count Spool detection to match parser's "Lazy Row Count Spool" PhysicalOp. Fix PlanTestHelper UTF-16 encoding handling for SSMS plans. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.internal/examples/PhysicalOp == "Row Count Spool"didn't match parser's"Lazy Row Count Spool"outputTest suite: 37 → 47 tests, all passing.
Test plan
dotnet test)🤖 Generated with Claude Code