Skip to content

Issue #48: Advice window styling, operator timing, rules, UI consistency#56

Merged
erikdarlingdata merged 1 commit intodevfrom
feature/issue-48-advice-styling
Mar 8, 2026
Merged

Issue #48: Advice window styling, operator timing, rules, UI consistency#56
erikdarlingdata merged 1 commit intodevfrom
feature/issue-48-advice-styling

Conversation

@erikdarlingdata
Copy link
Owner

Summary

  • Expensive operators: Multi-line format with both CPU and elapsed timing, node IDs for cross-referencing, fix for transparent operator CPU subtraction
  • New Rule 31: Parallel Wait Bottleneck — fires when elapsed >> CPU in parallel plans
  • Rule 25: Tightened Ineffective Parallelism threshold to 0.8–1.3
  • Warning formatting: Structured multi-line format with bullet stats for filter/lookup/predicate warnings; U+001F encoding to preserve internal newlines through line splitter
  • Advice window: SelectableTextBlock for copy/paste, color-coded timing lines, operator name detection
  • UI consistency: Server Context pane always visible (placeholder when no metadata), Runtime Summary empty state, disabled Query Store button in file-mode toolbar
  • Toolbar: Shortened button labels (Human Advice, Robot Advice, Copy Repro, Run Repro) to prevent overflow
  • Wait Stats: Wider panel (2* column, MinWidth=280)

Test plan

  • Open file-based .sqlplan — verify Server Context shows placeholder, Query Store button visible but disabled
  • Expensive operators show multi-line format with CPU/elapsed percentages and node IDs
  • Filter/lookup warnings render with bullet stats inside warning border (not escaping)
  • Toolbar buttons fit without overflow on standard 1080p+ display
  • All buttons visible in both Query Session and file-mode toolbars

🤖 Generated with Claude Code

Closes #48

…istency

- Expensive operators: multi-line format with CPU + elapsed, node IDs, transparent operator CPU fix
- Rule 25: tighten Ineffective Parallelism threshold to 0.8-1.3
- Rule 31: new Parallel Wait Bottleneck rule (elapsed >> CPU)
- Rules 1/10/12: structured multi-line warning format with bullet stats
- Warning newlines: escape with U+001F to survive line splitter, restore in AdviceContentBuilder
- Advice window: SelectableTextBlock for copy/paste, color-coded operator timing lines
- Plan Insights: Server Context pane always visible with placeholder, Runtime Summary empty state
- Toolbar: disabled Query Store button in file-mode, shortened button labels for space
- Wait Stats panel: wider column (2*) with MinWidth=280

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 1daca66 into dev Mar 8, 2026
2 checks passed
@erikdarlingdata erikdarlingdata deleted the feature/issue-48-advice-styling branch March 10, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant