fix: show suggestions for aliased bash-style flags#2
Merged
ericchansen merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
…ash-style flags Two bugs prevented PSCommandHelper from showing suggestions when users typed aliased commands with bash-style flags (e.g. rm -fr, ls -al): 1. Reverse alias lookup: When rm resolves to Remove-Item, the error's MyCommand.Name is 'Remove-Item', but the aliased map is keyed by 'rm'. Added Get-Alias -Definition reverse lookup to find the alias. 2. Flag-aware matching: Bash flags can be combined in any order (-rf = -fr) or separated (-r -f). Replaced substring regex matching with flag-set comparison that normalizes and compares flag characters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- add cmdlet-based fallback map for aliased entries so suggestions still resolve when bash alias names (rm/ls/cp/mv) are not present on the host OS - keep reverse alias lookup for environments where those aliases exist - clear cmdlet fallback cache on unregister - make reverse lookup tests platform-agnostic by validating alias-or-cmdlet fallback behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation