Skip to content

Feat/use azure client id to authenticate#256

Merged
atadj merged 4 commits intomainfrom
feat/use-azure-client-id-to-authenticate
Feb 20, 2026
Merged

Feat/use azure client id to authenticate#256
atadj merged 4 commits intomainfrom
feat/use-azure-client-id-to-authenticate

Conversation

@atadj
Copy link
Copy Markdown
Contributor

@atadj atadj commented Feb 18, 2026

Related to the issue #247

What I have made:

  • Getting the azure_client_id (env var)
  • try to authenticate using this azure_client_id
  • if it fails we log an error
  • if azure_client_id is not provided, keep same logic as before.

@atadj atadj requested a review from a team February 19, 2026 06:26
rwiker
rwiker reviewed Feb 19, 2026
View reviewed changes
Comment thread src/sumo/wrapper/sumo_client.py
rwiker
rwiker reviewed Feb 19, 2026
View reviewed changes
Comment thread src/sumo/wrapper/sumo_client.py
@atadj atadj requested a review from rwiker February 19, 2026 11:06
rwiker
rwiker reviewed Feb 19, 2026
View reviewed changes
Comment thread src/sumo/wrapper/sumo_client.py Outdated
@atadj atadj requested a review from rwiker February 19, 2026 11:54
rwiker
rwiker approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@atadj atadj merged commit 8c4d4a4 into main Feb 20, 2026
11 checks passed
@atadj atadj deleted the feat/use-azure-client-id-to-authenticate branch February 20, 2026 12:24
@equinor-ruaj equinor-ruaj mentioned this pull request Feb 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwiker rwiker rwiker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atadj @rwiker